Add support for MSI TV@nywhere Plus remote
PATCH 1/1 Add support for MSI TV@nywhere Plus remote
I've been carrying this patch, originally by Henry Wong, for a while. Here's the latest version, based off the linux master branch. I think it's ready for inclusion.
Rather than going on a probing spree, as in the previous version, I just probe a single address that's known to respond (0x50) as the workaround for the controller quirk. Also, the polling interval is no longer handled globally.
---
Add support for the MSI TV@nywhere Plus remote
The IR controller has a couple quirks. It won't respond until some other device on the bus is probed. To work around that, probe 0x50 first. Then, since it won't respond to a zero-byte read, probe with a one-byte read.
drivers/media/common/ir-keymaps.c +0 -0
@@ -467,7 +467,8 @@ EXPORT_SYMBOL_GPL(ir_codes_adstech_dvb_t_pci);
/* ---------------------------------------------------------------------- */
-/* MSI TV@nywhere remote */
+/* MSI TV@nywhere MASTER remote */
+
IR_KEYTAB_TYPE ir_codes_msi_tvanywhere[IR_KEYTAB_SIZE] = {
/* Keys 0 to 9 */
[ 0x00 ] = KEY_0,@@ -501,6 +502,96 @@ EXPORT_SYMBOL_GPL(ir_codes_msi_tvanywhere);
/* ---------------------------------------------------------------------- */
+/*
+ Keycodes for remote on the MSI TV@nywhere Plus. The controller IC on the card + is marked "KS003". The controller is I2C at address 0x30, but does not seem + to respond to probes until a read is performed from a valid device. + I don't know why... + + Note: This remote may be of similar or identical design to the + Pixelview remote (?). The raw codes and duplicate button codes + appear to be the same.
+
+ Henry Wong <[email protected]>
+ Some changes to formatting and keycodes by Mark Schultz <[email protected]> +
+*/
+
+IR_KEYTAB_TYPE ir_codes_msi_tvanywhere_plus[IR_KEYTAB_SIZE] = { +
+/* ---- Remote Button Layout ----
+
+ POWER SOURCE SCAN MUTE + TV/FM 1 2 3 + |> 4 5 6 + <| 7 8 9 + ^^UP 0 + RECALL + vvDN RECORD STOP PLAY
+
+ MINIMIZE ZOOM
+
+ CH+
+ VOL- VOL+
+ CH-
+
+ SNAPSHOT MTS
+
+ << FUNC >> RESET
+*/
+
+ [ 0x01 ] = KEY_KP1, /* 1 */ + [ 0x0B ] = KEY_KP2, /* 2 */ + [ 0x1B ] = KEY_KP3, /* 3 */ + [ 0x05 ] = KEY_KP4, /* 4 */ + [ 0x09 ] = KEY_KP5, /* 5 */ + [ 0x15 ] = KEY_KP6, /* 6 */ + [ 0x06 ] = KEY_KP7, /* 7 */ + [ 0x0A ] = KEY_KP8, /* 8 */ + [ 0x12 ] = KEY_KP9, /* 9 */ + [ 0x02 ] = KEY_KP0, /* 0 */ + [ 0x10 ] = KEY_KPPLUS, /* + */ + [ 0x13 ] = KEY_AGAIN, /* Recall */ + + [ 0x1E ] = KEY_POWER, /* Power */ + [ 0x07 ] = KEY_TUNER, /* Source */ + [ 0x1C ] = KEY_SEARCH, /* Scan */ + [ 0x18 ] = KEY_MUTE, /* Mute */ + + [ 0x03 ] = KEY_RADIO, /* TV/FM */ + /* The next four keys are duplicates that appear to send the + same IR code as Ch+, Ch-, >>, and << . The raw code assigned + to them is the actual code + 0x20 - they will never be + detected as such unless some way is discovered to distinguish + these buttons from those that have the same code. */ + [ 0x3F ] = KEY_RIGHT, /* |> and Ch+ */ + [ 0x37 ] = KEY_LEFT, /* <| and Ch- */ + [ 0x2C ] = KEY_UP, /* ^^Up and >> */ + [ 0x24 ] = KEY_DOWN, /* vvDn and << */ + + [ 0x00 ] = KEY_RECORD, /* Record */ + [ 0x08 ] = KEY_STOP, /* Stop */ + [ 0x11 ] = KEY_PLAY, /* Play */ + + [ 0x0F ] = KEY_CLOSE, /* Minimize */ + [ 0x19 ] = KEY_ZOOM, /* Zoom */ + [ 0x1A ] = KEY_SHUFFLE, /* Snapshot */ + [ 0x0D ] = KEY_LANGUAGE, /* MTS */ + + [ 0x14 ] = KEY_VOLUMEDOWN, /* Vol- */ + [ 0x16 ] = KEY_VOLUMEUP, /* Vol+ */ + [ 0x17 ] = KEY_CHANNELDOWN, /* Ch- */ + [ 0x1F ] = KEY_CHANNELUP, /* Ch+ */ + + [ 0x04 ] = KEY_REWIND, /* << */ + [ 0x0E ] = KEY_MENU, /* Function */ + [ 0x0C ] = KEY_FASTFORWARD, /* >> */ + [ 0x1D ] = KEY_RESTART, /* Reset */
+};
+
+EXPORT_SYMBOL_GPL(ir_codes_msi_tvanywhere_plus);
+
+/* ---------------------------------------------------------------------- */ +
/* Cinergy 1400 DVB-T */
IR_KEYTAB_TYPE ir_codes_cinergy_1400[IR_KEYTAB_SIZE] = {
[ 0x01 ] = KEY_POWER,drivers/media/video/ir-kbd-i2c.c +4 -0
@@ -12,6 +12,10 @@* Markus Rechberger <[email protected]> * modified for DViCO Fusion HDTV 5 RT GOLD by * Chaogui Zhang <[email protected]> +* modified for MSI TV@nywhere Plus by +* Henry Wong <[email protected]> +* Mark Schultz <[email protected]> +* Brian Rogers <[email protected]> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
@@ -224,9 +228,15 @@ static void ir_timer(unsigned long data)
static void ir_work(struct work_struct *work)
{
struct IR_i2c *ir = container_of(work, struct IR_i2c, work);+ int polling_interval = 100;
+
+ /* MSI TV@nywhere Plus requires more frequent polling
+ otherwise it will miss some keypresses */
+ if (ir->c.adapter->id == I2C_HW_SAA7134 && ir->c.addr == 0x30)
+ polling_interval = 50;
ir_key_poll(ir);
- mod_timer(&ir->timer, jiffies + msecs_to_jiffies(100));
+ mod_timer(&ir->timer, jiffies + msecs_to_jiffies(polling_interval));
}
/* ----------------------------------------------------------------------- */ @@ -465,9 +475,37 @@ static int ir_probe(struct i2c_adapter *adap)
(1 == rc) ? "yes" : "no");
if (1 == rc) {
ir_attach(adap, probe[i], 0, 0);
- break;
+ return 0;
}
}+
+ /* Special case for MSI TV@nywhere Plus remote */
+ if (adap->id == I2C_HW_SAA7134) {
+ u8 temp;
+
+ /* MSI TV@nywhere Plus controller doesn't seem to
+ respond to probes unless we read something from
+ an existing device. Weird... */
+
+ msg.addr = 0x50; + rc = i2c_transfer(adap, &msg, 1); + dprintk(1,"probe 0x%02x @ %s: %s\n",
+ msg.addr, adap->name,
+ (1 == rc) ? "yes" : "no");
+
+ /* Now do the probe. The controller does not respond
+ to 0-byte reads, so we use a 1-byte read instead. */
+ msg.addr = 0x30; + msg.len = 1; + msg.buf = &temp; + rc = i2c_transfer(adap, &msg, 1); + dprintk(1,"probe 0x%02x @ %s: %s\n",
+ msg.addr, adap->name,
+ (1 == rc) ? "yes" : "no");
+ if (1 == rc)
+ ir_attach(adap, msg.addr, 0, 0);
+ }
+
return 0; }
drivers/media/video/saa7134/saa7134-cards.c +1 -0
@@ -5745,6 +5745,7 @@ int saa7134_board_init1(struct saa7134_dev *dev)case SAA7134_BOARD_PINNACLE_PCTV_110i:case SAA7134_BOARD_PINNACLE_PCTV_310i:case SAA7134_BOARD_UPMOST_PURPLE_TV : +case SAA7134_BOARD_MSI_TVATANYWHERE_PLUS :case SAA7134_BOARD_HAUPPAUGE_HVR1110 :case SAA7134_BOARD_BEHOLD_607_9FM :case SAA7134_BOARD_BEHOLD_M6 :
drivers/media/video/saa7134/saa7134-i2c.c +1 -0
@@ -337,6 +337,7 @@ static int attach_inform(struct i2c_client *client)case 0x47 :case 0x71 :case 0x2d : +case 0x30 : {struct IR_i2c *ir =i2c_get_clientdata (client); d1printk("%s i2c IR detected (%s).\n",
drivers/media/video/saa7134/saa7134-input.c +0 -0
@@ -115,6 +115,52 @@ static int build_key(struct saa7134_dev *dev)
/* --------------------- Chip specific I2C key builders ----------------- */
+static int get_key_msi_tvanywhere_plus(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) +{
+ unsigned char b;
+ int rc;
+ int gpio;
+
+ /* <dev> is needed to access GPIO. Used by the saa_readl macro. */
+ struct saa7134_dev *dev = ir->c.adapter->algo_data;
+ if (dev == NULL) {+ dprintk("get_key_msi_tvanywhere_plus: gir->c.adapter->algo_data is NULL!\n");
+ return -EIO;
+ }
+
+ /* rising SAA7134_GPIO_GPRESCAN reads the status */
+
+ saa_clearb(SAA7134_GPIO_GPMODE3, SAA7134_GPIO_GPRESCAN);
+ saa_setb(SAA7134_GPIO_GPMODE3, SAA7134_GPIO_GPRESCAN);
+
+ gpio = saa_readl(SAA7134_GPIO_GPSTATUS0 >> 2);
+
+ /* GPIO&0x40 is pulsed low when a button is pressed. Don't do
+ I2C receive if gpio&0x40 is not low. */
+
+ if (gpio & 0x40)
+ return 0; /* No button press */
+
+ /* GPIO says there is a button press. Get it. */
+
+ if (1 != i2c_master_recv(&ir->c, &b, 1)) {
+ i2cdprintk("read error\n");
+ return -EIO;
+ }
+
+ /* No button press */
+
+ if (b == 0xFF)
+ return 0;
+
+ /* Button pressed */
+
+ dprintk("get_key_msi_tvanywhere_plus: Key = 0x%02X\n", b);
+ *ir_key = b;
+ *ir_raw = b;
+ return 1;
+}
+
static int get_key_purpletv(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
{
unsigned char b;
@@ -612,6 +658,11 @@ void saa7134_set_i2c_ir(struct saa7134_dev *dev, struct IR_i2c *ir)
ir->get_key = get_key_purpletv;
ir->ir_codes = ir_codes_purpletv;
break;
+ case SAA7134_BOARD_MSI_TVATANYWHERE_PLUS:
+ snprintf(ir->c.name, sizeof(ir->c.name), "MSI TV@nywhere Plus");
+ ir->get_key = get_key_msi_tvanywhere_plus;
+ ir->ir_codes = ir_codes_msi_tvanywhere_plus;
+ break;
case SAA7134_BOARD_HAUPPAUGE_HVR1110:
snprintf(ir->c.name, sizeof(ir->c.name), "HVR 1110");
ir->get_key = get_key_hvr1110;include/media/ir-common.h +0 -0
@@ -147,6 +147,7 @@ extern IR_KEYTAB_TYPE ir_codes_pinnacle_pctv_hd[IR_KEYTAB_SIZE];
extern IR_KEYTAB_TYPE ir_codes_genius_tvgo_a11mce[IR_KEYTAB_SIZE]; extern IR_KEYTAB_TYPE ir_codes_powercolor_real_angel[IR_KEYTAB_SIZE]; extern IR_KEYTAB_TYPE ir_codes_avermedia_a16d[IR_KEYTAB_SIZE]; +extern IR_KEYTAB_TYPE ir_codes_msi_tvanywhere_plus[IR_KEYTAB_SIZE];
#endif
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
Quoted 8 lines · Mauro Carvalho Chehab
The patch looks good. However, it has two issues:
1) Your emailer corrupted it, by replacing tabs by spaces, and wrapping
lines. So, the patch doesn't apply:$ patch -p1 -i /tmp/patches --dry-run -d linux patching file drivers/media/common/ir-keymaps.c patch: **** malformed patch at line 68: [ 0x00 ] = KEY_0,
OK, I'm attaching the file this time.
Quoted 8 lines
The better is to check your patch against the checkpatch.pl script (at kernel tree and at
v4l/scripts/checkpatch.pl). If you have a tree cloned from hg, the easiest way is to apply your patch at the tree and use "make checkpatch" before committing it).Side note: Yes, I know that there are a large amount of style violations at the current drivers. The idea is trying to avoid adding even more ;)
I actually ran that tool, but I skipped over the rules that were being broken at almost every opportunity, for consistency. :) This time I fixed everything.
Add support for the MSI TV@nywhere Plus remote
The IR controller has a couple quirks. It won't respond until some other device on the bus is probed. To work around that, probe 0x50 first. Then, since it won't respond to a zero-byte read, probe with a one-byte read.
drivers/media/common/ir-keymaps.c +91 -1
@@ -467,7 +467,8 @@ EXPORT_SYMBOL_GPL(ir_codes_adstech_dvb_t_pci);/* ---------------------------------------------------------------------- */ -/* MSI TV@nywhere remote */ +/* MSI TV@nywhere MASTER remote */ +IR_KEYTAB_TYPE ir_codes_msi_tvanywhere[IR_KEYTAB_SIZE ] = {/* Keys 0 to 9 */ [0x00 ] =KEY_0 ,
@@ -501,6 +502,95 @@ EXPORT_SYMBOL_GPL(ir_codes_msi_tvanywhere);/* ---------------------------------------------------------------------- */ +/* +Keycodes for remote on the MSI TV@nywhere Plus. The controller IC on the card +is marked "KS003". The controller is I2C at address 0x30, but does not seem +to respond to probes until a read is performed from a valid device. +I don't know why... + +Note: This remote may be of similar or identical design to the +Pixelview remote (?). The raw codes and duplicate button codes +appear to be the same. + +Henry Wong <[email protected]> +Some changes to formatting and keycodes by Mark Schultz <[email protected]> + +*/ + +IR_KEYTAB_TYPE ir_codes_msi_tvanywhere_plus[IR_KEYTAB_SIZE ] = { + +/* ---- Remote Button Layout ---- + +POWER SOURCE SCAN MUTE +TV/FM 1 2 3 +|> 4 5 6 +<| 7 8 9 +^^UP 0 + RECALL +vvDN RECORD STOP PLAY + +MINIMIZE ZOOM + +CH+ +VOL- VOL+ +CH- + +SNAPSHOT MTS + +<< FUNC >> RESET +*/ + + [0x01 ] =KEY_KP1 ,/* 1 */ + [0x0b ] =KEY_KP2 ,/* 2 */ + [0x1b ] =KEY_KP3 ,/* 3 */ + [0x05 ] =KEY_KP4 ,/* 4 */ + [0x09 ] =KEY_KP5 ,/* 5 */ + [0x15 ] =KEY_KP6 ,/* 6 */ + [0x06 ] =KEY_KP7 ,/* 7 */ + [0x0a ] =KEY_KP8 ,/* 8 */ + [0x12 ] =KEY_KP9 ,/* 9 */ + [0x02 ] =KEY_KP0 ,/* 0 */ + [0x10 ] =KEY_KPPLUS ,/* + */ + [0x13 ] =KEY_AGAIN ,/* Recall */ + + [0x1e ] =KEY_POWER ,/* Power */ + [0x07 ] =KEY_TUNER ,/* Source */ + [0x1c ] =KEY_SEARCH ,/* Scan */ + [0x18 ] =KEY_MUTE ,/* Mute */ + + [0x03 ] =KEY_RADIO ,/* TV/FM */ +/* The next four keys are duplicates that appear to send the +same IR code as Ch+, Ch-, >>, and << . The raw code assigned +to them is the actual code + 0x20 - they will never be +detected as such unless some way is discovered to distinguish +these buttons from those that have the same code. */ + [0x3f ] =KEY_RIGHT ,/* |> and Ch+ */ + [0x37 ] =KEY_LEFT ,/* <| and Ch- */ + [0x2c ] =KEY_UP ,/* ^^Up and >> */ + [0x24 ] =KEY_DOWN ,/* vvDn and << */ + + [0x00 ] =KEY_RECORD ,/* Record */ + [0x08 ] =KEY_STOP ,/* Stop */ + [0x11 ] =KEY_PLAY ,/* Play */ + + [0x0f ] =KEY_CLOSE ,/* Minimize */ + [0x19 ] =KEY_ZOOM ,/* Zoom */ + [0x1a ] =KEY_SHUFFLE ,/* Snapshot */ + [0x0d ] =KEY_LANGUAGE ,/* MTS */ + + [0x14 ] =KEY_VOLUMEDOWN ,/* Vol- */ + [0x16 ] =KEY_VOLUMEUP ,/* Vol+ */ + [0x17 ] =KEY_CHANNELDOWN ,/* Ch- */ + [0x1f ] =KEY_CHANNELUP ,/* Ch+ */ + + [0x04 ] =KEY_REWIND ,/* << */ + [0x0e ] =KEY_MENU ,/* Function */ + [0x0c ] =KEY_FASTFORWARD ,/* >> */ + [0x1d ] =KEY_RESTART ,/* Reset */ +}; +EXPORT_SYMBOL_GPL (ir_codes_msi_tvanywhere_plus); + +/* ---------------------------------------------------------------------- */ +/* Cinergy 1400 DVB-T */ IR_KEYTAB_TYPE ir_codes_cinergy_1400[IR_KEYTAB_SIZE ] = { [0x01 ] =KEY_POWER ,
drivers/media/video/ir-kbd-i2c.c +40 -2
64 lines not on this page · raw message
drivers/media/video/saa7134/saa7134-cards.c +1 -0
@@ -5745,6 +5745,7 @@ int saa7134_board_init1(struct saa7134_dev *dev)case SAA7134_BOARD_PINNACLE_PCTV_110i:case SAA7134_BOARD_PINNACLE_PCTV_310i:case SAA7134_BOARD_UPMOST_PURPLE_TV : +case SAA7134_BOARD_MSI_TVATANYWHERE_PLUS :case SAA7134_BOARD_HAUPPAUGE_HVR1110 :case SAA7134_BOARD_BEHOLD_607_9FM :case SAA7134_BOARD_BEHOLD_M6 :
drivers/media/video/saa7134/saa7134-i2c.c +1 -0
@@ -337,6 +337,7 @@ static int attach_inform(struct i2c_client *client)case 0x47 :case 0x71 :case 0x2d : +case 0x30 : {struct IR_i2c *ir =i2c_get_clientdata (client); d1printk("%s i2c IR detected (%s).\n",
drivers/media/video/saa7134/saa7134-input.c +53 -0
65 lines not on this page · raw message
include/media/ir-common.h +1 -0
@@ -147,6 +147,7 @@ extern IR_KEYTAB_TYPE ir_codes_pinnacle_pctv_hd[IR_KEYTAB_SIZE];extern IR_KEYTAB_TYPE ir_codes_genius_tvgo_a11mce[IR_KEYTAB_SIZE ];extern IR_KEYTAB_TYPE ir_codes_powercolor_real_angel[IR_KEYTAB_SIZE ];extern IR_KEYTAB_TYPE ir_codes_avermedia_a16d[IR_KEYTAB_SIZE ]; +extern IR_KEYTAB_TYPE ir_codes_msi_tvanywhere_plus[IR_KEYTAB_SIZE ];#endif
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
Am Donnerstag, den 11.09.2008, 10:38 -0300 schrieb Mauro Carvalho Chehab:
Quoted 42 lines
Hi Brian,
Quoted 8 lines · On Mon, 08 Sep 2008 03:19:11 -0700 Brian Rogers <[email protected]>…
I've been carrying this patch, originally by Henry Wong, for a while. Here's the latest version, based off the linux master branch. I think it's ready for inclusion.
Rather than going on a probing spree, as in the previous version, I just probe a single address that's known to respond (
0x50) as the workaround for the controller quirk. Also, the polling interval is no longer handled globally.The patch looks good. However, it has two issues:
1) Your emailer corrupted it, by replacing tabs by spaces, and wrapping
lines. So, the patch doesn't apply:$ patch -p1 -i /tmp/patches --dry-run -d linux patching file drivers/media/common/ir-keymaps.c patch: **** malformed patch at line 68: [ 0x00 ] = KEY_0,2) There are a number of coding style violations. The main points are:
- Use tabs instead of spaces to indent (I suspect that this trouble happens due to your emailer). A tab corresponds to 8 columns at kernel;
- don't use spaces between brackets. So, newer IR tables should be:
[0x1d] = KEY_foo;- Use lower case for hexadecimal values (instead of
0x1D, prefer to use0x1d);- Use space after comma;
- Avoid using lines with more than 80 cols.
The better is to check your patch against the checkpatch.pl script (at kernel tree and at
v4l/scripts/checkpatch.pl). If you have a tree cloned from hg, the easiest way is to apply your patch at the tree and use "make checkpatch" before committing it).
Quoted 5 lines
Side note: Yes, I know that there are a large amount of style violations at the current drivers. The idea is trying to avoid adding even more ;)
Cheers,
Mauro
Mauro,
this is the oldest and most important outstanding patch we have.
There are whole generations of cards still without of any IR support, since years, because of that.
If this one should still hang on coding style violations, please let me know.
If you would ever find time again, have a look at my patch enabling first support for the new Asus Tiger 3in1, which I have only as an OEM board, but which is coming up to global distribution now and likely will cover all newer boards.
I'm still not related to them and never asked a single question.
But with the OEM version we likely have support for both new variants too. As previously, I can't confirm for the IR on that OEM, but guess previous work was not in vain!
All previous is correct, but the composite input on vmux 3 does not exist and we don't need any other gpio21 switch, except for radio.
I wasted some time again, to fit into the 80 columns rule on saaa7134-dvb.c, and all I can say is, this way not with me.
Please exercise it yourself now, you have all relevant information, show the resulting code and explain, why such crap should be looking good.
BTW, editors can break down lines, if needed, since close to ever, and mark it even for the blindest.
Cheers,
Hermann
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
Quoted 9 lines · On Sun, 14 Sep 2008 04:35:19 +0200 hermann pitton <[email protected]>…
Mauro,
this is the oldest and most important outstanding patch we have.
There are whole generations of cards still without of any IR support, since years, because of that.
If this one should still hang on coding style violations, please let me know.
I'll handle this patch soon. I'm currently away (in Portland, due to Plumbers and KS conferences), so, maybe I'll wait until the next week for committing it.
Quoted 4 lines
If you would ever find time again, have a look at my patch enabling first support for the new Asus Tiger 3in1, which I have only as an OEM board, but which is coming up to global distribution now and likely will cover all newer boards.
Could you please forward it me again any pending patches? Better if you can do it at the beginning of the next week. If I don't answer about a patch in about one week, the better is to ping me about it.
Quoted 2 lines
I wasted some time again, to fit into the 80 columns rule on
saaa7134-dvb.c, and all I can say is, this way not with me.
The 80 cols rule is just a warning. On some cases, it helps to improve readability. Also, it is generally easier to review codes that fit on 80 cols, since it helps me to open a window comparing a file and a patched version with some tool like kdiff3, where the several file revisions are presented side by side.
Quoted 2 lines
Please exercise it yourself now, you have all relevant information, show the resulting code and explain, why such crap should be looking good.
I did my self some coding style patches and the end result was an easier to read code. As already discussed, such warnings/errors should be used as a hint of troubles, not as absolute rules.
Cheers,
Mauro.
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
Hi,
Am Montag, den 15.09.2008, 01:26 -0300 schrieb Mauro Carvalho Chehab:
Quoted 7 lines
Quoted 4 lines · On Sun, 14 Sep 2008 04:35:19 +0200 hermann pitton <[email protected]>…
Mauro,
this is the oldest and most important outstanding patch we have.
Quoted 8 lines
Quoted 5 lines
There are whole generations of cards still without of any IR support, since years, because of that.
If this one should still hang on coding style violations, please let me know.
I'll handle this patch soon. I'm currently away (in Portland, due to Plumbers and KS conferences), so, maybe I'll wait until the next week for committing it.
fine. My small other stuff will cause no merge conflicts.
Quoted 17 lines
Quoted 4 lines
If you would ever find time again, have a look at my patch enabling first support for the new Asus Tiger 3in1, which I have only as an OEM board, but which is coming up to global distribution now and likely will cover all newer boards.
Could you please forward it me again any pending patches? Better if you can do it at the beginning of the next week. If I don't answer about a patch in about one week, the better is to ping me about it.
Quoted 2 lines
I wasted some time again, to fit into the 80 columns rule on
saaa7134-dvb.c, and all I can say is, this way not with me.The 80 cols rule is just a warning. On some cases, it helps to improve readability. Also, it is generally easier to review codes that fit on 80 cols, since it helps me to open a window comparing a file and a patched version with some tool like kdiff3, where the several file revisions are presented side by side.
Quoted 7 lines
Quoted 2 lines
Please exercise it yourself now, you have all relevant information, show the resulting code and explain, why such crap should be looking good.
I did my self some coding style patches and the end result was an easier to read code. As already discussed, such warnings/errors should be used as a hint of troubles, not as absolute rules.
I cooled down next day and a patch within 80 columns is on the lists :)
Please pick up this one first and report any issues.
I'll provide the other few patches then next weekend.
Good times in Portland, peace and cooperation.
Cheers,
Hermann
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
Quoted 7 lines · Mauro Carvalho Chehab
Quoted 4 lines · On Sun, 14 Sep 2008 04:35:19 +0200 hermann pitton <[email protected]>…
Mauro,
this is the oldest and most important outstanding patch we have.
Quoted 9 lines
Quoted 6 lines
There are whole generations of cards still without of any IR support, since years, because of that.
If this one should still hang on coding style violations, please let me know.
I'll handle this patch soon. I'm currently away (in Portland, due to Plumbers and KS conferences), so, maybe I'll wait until the next week for committing it.
The patch doesn't appear to be in any of the v4l trees yet, so here's a ping to remind you.
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list