Skip to contentSkip to conversation

physmap.c: Add #endif comments

PATCH In review Zev Weiss 2 participants 3 messages Sep 13, 2008 Memory technology devices (MTD)

lore
Share & tools
lore

Zev Weiss

author
#0 lore raw

PATCH 2/3 physmap.c: Add #endif comments

Adding comments to a few of the less painfully-obvious #endifs.

Signed-off-by Zev Weiss <[email protected]>
---
 drivers/mtd/maps/physmap.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/mtd/maps/physmap.c +1 -1
index 6fba0d4..49e2039 100644
@@ -244,7 +244,7 @@ static void physmap_flash_shutdown(struct platform_device *dev)
 #define physmap_flash_suspend NULL
 #define physmap_flash_resume NULL
 #define physmap_flash_shutdown NULL
-#endif
+#endif /* CONFIG_PM */
 
 static struct platform_driver physmap_flash_driver = {
 	.probe		= physmap_flash_probe,

@@ -302,8 +302,8 @@ void physmap_set_partitions(struct mtd_partition *parts, int

num_parts)
physmap_flash_data.nr_parts = num_parts;
physmap_flash_data.parts = parts;
}
-#endif
-#endif
+#endif /* CONFIG_MTD_PARTITIONS */
+#endif /* PHYSMAP_COMPAT */

static int __init physmap_init(void)
{

Signature · 1 line
1.5.4.1
#1 lore raw
Quoted 21 lines · Zev Weiss

Adding comments to a few of the less painfully-obvious #endifs.

Signed-off-by Zev Weiss <[email protected]>
---
  drivers/mtd/maps/physmap.c |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)
drivers/mtd/maps/physmap.c +1 -1
index 6fba0d4..49e2039 100644
@@ -244,7 +244,7 @@ static void physmap_flash_shutdown(struct platform_device *dev)
  #define physmap_flash_suspend NULL
  #define physmap_flash_resume NULL
  #define physmap_flash_shutdown NULL
-#endif
+#endif /* CONFIG_PM */
 
  static struct platform_driver physmap_flash_driver = {
  	.probe		= physmap_flash_probe,

drivers/mtd/maps/physmap.c void physmap_set_partitions(struct mtd_partition *parts, int · line 307

Quoted 8 lines
drivers/mtd/maps/physmap.c +2 -2
@@ -302,8 +302,8 @@ void physmap_set_partitions(struct mtd_partition *parts, int
 num_parts)
  	physmap_flash_data.nr_parts = num_parts;
  	physmap_flash_data.parts = parts;
  }
-#endif
-#endif
+#endif /* CONFIG_MTD_PARTITIONS */
+#endif /* PHYSMAP_COMPAT */

I thought that this was frowned upon. (I don't like it myself, and my editor is perfectly well capable of pointing out to me which ifdef matches up with which endif.)

author
#2 lore raw
Quoted 20 lines · Lennert Buytenhek
Quoted 18 lines · Zev Weiss

Adding comments to a few of the less painfully-obvious #endifs.

Signed-off-by Zev Weiss <[email protected]>
---
  drivers/mtd/maps/physmap.c |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)
drivers/mtd/maps/physmap.c +1 -1
index 6fba0d4..49e2039 100644
@@ -244,7 +244,7 @@ static void physmap_flash_shutdown(struct platform_device *dev)
  #define physmap_flash_suspend NULL
  #define physmap_flash_resume NULL
  #define physmap_flash_shutdown NULL
-#endif
+#endif /* CONFIG_PM */
Quoted 16 lines

drivers/mtd/maps/physmap.c void physmap_set_partitions(struct mtd_partition *parts, int · line 307

Quoted 11 lines
drivers/mtd/maps/physmap.c +2 -2
  static struct platform_driver physmap_flash_driver = {
  	.probe		= physmap_flash_probe,

@@ -302,8 +302,8 @@ void physmap_set_partitions(struct mtd_partition *parts, int
 num_parts)
  	physmap_flash_data.nr_parts = num_parts;
  	physmap_flash_data.parts = parts;
  }
-#endif
-#endif
+#endif /* CONFIG_MTD_PARTITIONS */
+#endif /* PHYSMAP_COMPAT */

I thought that this was frowned upon. (I don't like it myself, and my editor is perfectly well capable of pointing out to me which ifdef matches up with which endif.)

Ah, OK -- I found it slightly hard to follow the ones that get longer than a screenful or so, and I don't have my editor set to match them up nicely (though I might look into that). It's something I'm accustomed to doing and seeing, and I saw no mention of it one way or another in Documentation/CodingStyle, so I didn't really give it a second thought.