physmap.c: Add a dummy release function
PATCH 3/3 physmap.c: Add a dummy release function
Adding a dummy release function to the physmap device so as to silence a log warning on initialization.
--- drivers/mtd/maps/physmap.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/mtd/maps/physmap.c +5 -0
@@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = { .flags = IORESOURCE_MEM, }; +static void physmap_dummy_release (struct device *dev) +{ +} +static struct platform_device physmap_flash = { .name ="physmap-flash" , .id =0 , .dev = { .platform_data = &physmap_flash_data, + .release = &physmap_dummy_release, }, .num_resources =1 , .resource = &physmap_flash_resource,
Signature · 1 line
1.5.4.1
Quoted 19 lines · Zev Weiss
Adding a dummy release function to the physmap device so as to silence a log warning on initialization.
Signed-off-by Zev Weiss <[email protected]>--- drivers/mtd/maps/physmap.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)drivers/mtd/maps/physmap.c +3
-0@@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = { .flags = IORESOURCE_MEM, }; +static void physmap_dummy_release (struct device *dev) +{ +}
drivers/mtd/maps/physmap.c static struct resource physmap_flash_resource = { · line 292
Quoted 10 lines
drivers/mtd/maps/physmap.c +2
-0+static struct platform_device physmap_flash = { .name ="physmap-flash" , .id =0 , .dev = { .platform_data = &physmap_flash_data, + .release = &physmap_dummy_release, }, .num_resources =1 , .resource = &physmap_flash_resource,
Isn't that just papering over the issue?
Quoted 18 lines · Lennert Buytenhek
Quoted 16 lines · Zev Weiss
Adding a dummy release function to the physmap device so as to silence a log warning on initialization.
Signed-off-by Zev Weiss <[email protected]>--- drivers/mtd/maps/physmap.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)drivers/mtd/maps/physmap.c +0
-0@@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = { .flags = IORESOURCE_MEM, };
Quoted 16 lines
drivers/mtd/maps/physmap.c static struct resource physmap_flash_resource = { · line 292
Quoted 13 lines
drivers/mtd/maps/physmap.c +5
-0+static void physmap_dummy_release (struct device *dev) +{ +} +static struct platform_device physmap_flash = { .name ="physmap-flash" , .id =0 , .dev = { .platform_data = &physmap_flash_data, + .release = &physmap_dummy_release, }, .num_resources =1 , .resource = &physmap_flash_resource,Isn't that just papering over the issue?
Quite possibly -- is there something it *should* be doing? (I don't mean to suggest I particularly think there's not, honest question.) I had figured it was a minor oversight and the warning was sort of a "spurious" one, though I'm admittedly well out of my depth here, so perhaps I shouldn't be doing such things (though I suppose it's one way to learn).
Quoted 2 lines
Subject: [PATCH 3/3] [MTD]
physmap.c: Add a dummy release function
Please avoid putting the "MTD" inside the [] characters. Anything which is inside [] is supposed to be discarded by the patch-receiving party. This is for things like [rfc], [patch 3/12], [2.6.27-rc5], etc.
But we do want the "mtd" text to go all the way through into the mainline git metadata.
Quoted 20 lines · On Fri, 12 Sep 2008 23:33:08 -0700 Zev Weiss <[email protected]> wrote:
Adding a dummy release function to the physmap device so as to silence a log warning on initialization.
Signed-off-by Zev Weiss <[email protected]>--- drivers/mtd/maps/physmap.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)drivers/mtd/maps/physmap.c +3
-0@@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = { .flags = IORESOURCE_MEM, }; +static void physmap_dummy_release (struct device *dev) +{ +}
drivers/mtd/maps/physmap.c static struct resource physmap_flash_resource = { · line 292
Quoted 10 lines
drivers/mtd/maps/physmap.c +2
-0+static struct platform_device physmap_flash = { .name ="physmap-flash" , .id =0 , .dev = { .platform_data = &physmap_flash_data, + .release = &physmap_dummy_release, }, .num_resources =1 , .resource = &physmap_flash_resource,
Nope. Please see Documentation/kobject.txt - search for the text "mocked mercilessly".