Skip to contentSkip to conversation

rt2x00: Consolidate definition of CSR_OFFSET

PATCH Ivo Van Doorn 1 participant 1 message Sep 19, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ivo Van Doorn

author NAK
#1 lore raw
Quoted 8 lines · John Daiker

This consolidates the definition of CSR_OFFSET when CONFIG_RT2X00_LIB_DEBUG is also set.
The original definition appeared in 5 files, but was moved to a common .h file instead.

Compile-tested only, as I don't have any rt2x00 HW in a working machine.

NACK
This patch does more then consolidating the CRS_OFFSET definition since it changes several lines for adding/removing whitespaces as well. It completely breaks rt2500usb, and I really dislike using define names in rt2x00.h
while the define itself is declared in the register headers only (and is thus not really
visible in rt2x00.h, even though the compiler would accept it and it would work as
expected).

Ivo

Quoted 4 lines

---