Skip to contentSkip to conversation

documentation: xip documentation update

PATCH Superseded Marco Stornelli 2 participants 4 messages Sep 22, 2008 – Sep 23, 2008 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 documentation: xip documentation update

From: Marco Stornelli <[email protected]>

xip documentation updated

---

Documentation/filesystems/xip.txt renamed from Documentation/filesystems/xip.txt.orig +5 -4
@@ -39,10 +39,11 @@ The block device operation is optional,
 today:
 - dcssblk: s390 dcss block device driver
 
-An address space operation named get_xip_page is used to retrieve reference
-to a struct page. To address the target page, a reference to an address_space,
-and a sector number is provided. A 3rd argument indicates whether the
-function should allocate blocks if needed.
+An address space operation named get_xip_mem is used to retrieve reference
+to a page frame number and a kernel address. To obtain these values a reference
+to an address_space is provided. This function is in charge to assign values to
+the pointers kmem and pfn. The 3rd argument indicates whether the function 
+should allocate blocks if needed.
 
 This address space operation is mutually exclusive with readpage&writepage that
 do page cache read/write operations.
#1 lore raw
Quoted 9 lines · On Mon, 22 Sep 2008 11:37:52 +0200 Marco Stornelli wrote:

From: Marco Stornelli <[email protected]>

xip documentation updated

---

Documentation/filesystems/xip.txt The block device operation is optional, · line 44

Quoted 10 lines
Documentation/filesystems/xip.txt renamed from Documentation/filesystems/xip.txt.orig +3 -4
@@ -39,10 +39,11 @@ The block device operation is optional,
 today:
 - dcssblk: s390 dcss block device driver
 
-An address space operation named get_xip_page is used to retrieve reference
-to a struct page. To address the target page, a reference to an address_space,
-and a sector number is provided. A 3rd argument indicates whether the
-function should allocate blocks if needed.
+An address space operation named get_xip_mem is used to retrieve reference
+to a page frame number and a kernel address. To obtain these values a reference
+to an address_space is provided. This function is in charge to assign values to

How about:
This function assigns values to the kmem and
pfn parameters.

Documentation/filesystems/xip.txt The block device operation is optional, · line 49

Quoted 5 lines
Documentation/filesystems/xip.txt renamed from Documentation/filesystems/xip.txt.orig +2 -0
+the pointers kmem and pfn. The 3rd argument indicates whether the function 
+should allocate blocks if needed.
 
 This address space operation is mutually exclusive with readpage&writepage that
 do page cache read/write operations.

Thanks.

---
~Randy

#2 lore raw

Ok, have I to submit the patch again with this new line?

Randy Dunlap ha scritto:

Quoted 38 lines · On Mon, 22 Sep 2008 11:37:52 +0200 Marco Stornelli wrote:
Quoted 10 lines

From: Marco Stornelli <[email protected]>

xip documentation updated

---

Documentation/filesystems/xip.txt The block device operation is optional, · line 44

Quoted 10 lines
Documentation/filesystems/xip.txt renamed from Documentation/filesystems/xip.txt.orig +3 -4
@@ -39,10 +39,11 @@ The block device operation is optional,
 today:
 - dcssblk: s390 dcss block device driver
 
-An address space operation named get_xip_page is used to retrieve reference
-to a struct page. To address the target page, a reference to an address_space,
-and a sector number is provided. A 3rd argument indicates whether the
-function should allocate blocks if needed.
+An address space operation named get_xip_mem is used to retrieve reference
+to a page frame number and a kernel address. To obtain these values a reference
+to an address_space is provided. This function is in charge to assign values to

How about:
This function assigns values to the kmem and
pfn parameters.

Documentation/filesystems/xip.txt The block device operation is optional, · line 49

Quoted 5 lines
Documentation/filesystems/xip.txt renamed from Documentation/filesystems/xip.txt.orig +2 -0
+the pointers kmem and pfn. The 3rd argument indicates whether the function 
+should allocate blocks if needed.
 
 This address space operation is mutually exclusive with readpage&writepage that
 do page cache read/write operations.

Thanks.

---
~Randy

Signature · 7 lines
Marco Stornelli
Embedded Software Engineer
CoRiTeL - Consorzio di Ricerca sulle Telecomunicazioni
http://www.coritel.it

[email protected]
+39 06 72582838
#3 lore raw
In reply to Randy Dunlap

From: Marco Stornelli <[email protected]>

Fix xip documentation with the comments of Randy Dunlap.

---

Documentation/filesystems/xip.txt renamed from Documentation/filesystems/xip.txt.orig +5 -4
@@ -39,10 +39,11 @@ The block device operation is optional,
 today:
 - dcssblk: s390 dcss block device driver
 
-An address space operation named get_xip_page is used to retrieve reference
-to a struct page. To address the target page, a reference to an address_space,
-and a sector number is provided. A 3rd argument indicates whether the
-function should allocate blocks if needed.
+An address space operation named get_xip_mem is used to retrieve reference
+to a page frame number and a kernel address. To obtain these values a reference
+to an address_space is provided. This function assigns values to the kmem and
+pfn parameters. The 3rd argument indicates whether the function should allocate
+blocks if needed.
 
 This address space operation is mutually exclusive with readpage&writepage that
 do page cache read/write operations.

Randy Dunlap ha scritto:

Quoted 38 lines · On Mon, 22 Sep 2008 11:37:52 +0200 Marco Stornelli wrote:
Quoted 10 lines

From: Marco Stornelli <[email protected]>

xip documentation updated

---

Documentation/filesystems/xip.txt The block device operation is optional, · line 44

Quoted 10 lines
Documentation/filesystems/xip.txt renamed from Documentation/filesystems/xip.txt.orig +3 -4
@@ -39,10 +39,11 @@ The block device operation is optional,
 today:
 - dcssblk: s390 dcss block device driver
 
-An address space operation named get_xip_page is used to retrieve reference
-to a struct page. To address the target page, a reference to an address_space,
-and a sector number is provided. A 3rd argument indicates whether the
-function should allocate blocks if needed.
+An address space operation named get_xip_mem is used to retrieve reference
+to a page frame number and a kernel address. To obtain these values a reference
+to an address_space is provided. This function is in charge to assign values to

How about:
This function assigns values to the kmem and
pfn parameters.

Documentation/filesystems/xip.txt The block device operation is optional, · line 49

Quoted 5 lines
Documentation/filesystems/xip.txt renamed from Documentation/filesystems/xip.txt.orig +2 -0
+the pointers kmem and pfn. The 3rd argument indicates whether the function 
+should allocate blocks if needed.
 
 This address space operation is mutually exclusive with readpage&writepage that
 do page cache read/write operations.

Thanks.

---
~Randy