Skip to contentSkip to conversation

block: installing include/linux/blktrace_api.h

PATCH In review John Jolly 3 participants 3 messages Sep 24, 2008 – Oct 2, 2008

lore
Share & tools
lore

John Jolly

author
#0 lore raw

PATCH 1/1 block: installing include/linux/blktrace_api.h

From: John Jolly <[email protected]>

Added line to install include/linux/blktrace_api.h during 'make headers_install'

---
 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/Kbuild +1 -0
index b68ec09..f1e5fa1 100644
@@ -41,6 +41,7 @@ header-y += baycom.h
 header-y += bfs_fs.h
 header-y += blkpg.h
 header-y += bpqether.h
+header-y += blktrace_api.h
 header-y += can.h
 header-y += cdk.h
 header-y += chio.h
#1 lore raw
Quoted 16 lines · On Wed, 24 Sep 2008 08:47:51 -0600 John Jolly <[email protected]> wrote:

From: John Jolly <[email protected]>

Added line to install include/linux/blktrace_api.h during 'make headers_install'

---
 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/Kbuild +0 -0
index b68ec09..f1e5fa1 100644

include/linux/Kbuild header-y += baycom.h · line 47

Quoted 7 lines
include/linux/Kbuild +1 -0
@@ -41,6 +41,7 @@ header-y += baycom.h
 header-y += bfs_fs.h
 header-y += blkpg.h
 header-y += bpqether.h
+header-y += blktrace_api.h
 header-y += can.h
 header-y += cdk.h
 header-y += chio.h

The two basic and almost always necessary parts of a patch changelog are

a) what was changed and

b) why the change was made

Your changelog had no b), hence nobody is likely to apply the patch.

#2 lore raw
Quoted 26 lines · Andrew Morton
Quoted 16 lines · On Wed, 24 Sep 2008 08:47:51 -0600 John Jolly <[email protected]> wrote:

From: John Jolly <[email protected]>

Added line to install include/linux/blktrace_api.h during 'make headers_install'

---
 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/Kbuild +0 -0
index b68ec09..f1e5fa1 100644

include/linux/Kbuild header-y += baycom.h · line 47

Quoted 7 lines
include/linux/Kbuild +1 -0
@@ -41,6 +41,7 @@ header-y += baycom.h
 header-y += bfs_fs.h
 header-y += blkpg.h
 header-y += bpqether.h
+header-y += blktrace_api.h
 header-y += can.h
 header-y += cdk.h
 header-y += chio.h

The two basic and almost always necessary parts of a patch changelog are

Quoted 5 lines

a) what was changed and

b) why the change was made

Your changelog had no b), hence nobody is likely to apply the patch.

A similar patch is already merged for 2.6.28 as well.

Signature · 1 line
Jens Axboe