compiler warning after applying btree patches
Christoph,
After applying the first round of btree patches we've now got this warning when building a non-debug xfs module.
CC fs/xfs/xfs_btree.ofs/xfs/xfs_btree.c:191: warning: ‘xfs_btree_check_ptr’ defined but not used
I took a quick look through your next round of btree patches but couldn't see a fix for it. Did I miss something in the original patch set? Is it fixed in a later patch? If not here's a fix:
fs/xfs/xfs_btree.c +0 -0
@@ -160,6 +160,7 @@ xfs_btree_check_lptr(
return 0; }
+#ifdef DEBUG
/*
* Check that (short) pointer is ok.
*/
@@ -197,6 +198,7 @@ xfs_btree_check_ptr(
be32_to_cpu((&ptr->s)[index]), level); } }
+#endif
/*
* Delete the btree cursor.
Quoted 11 lines · Lachlan McIlroy
Christoph,
After applying the first round of btree patches we've now got this warning when building a non-debug xfs module.
CC
fs/xfs/xfs_btree.ofs/xfs/xfs_btree.c:191: warning: ?xfs_btree_check_ptr? defined but not usedI took a quick look through your next round of btree patches but couldn't see a fix for it. Did I miss something in the original patch set? Is it fixed in a later patch? If not here's a fix:
No, it's not used for now. For some reason I missed the warning.
The patch looks good, can you also put it into xfs-cmds so the two copies stay in sync?
Quoted 9 lines · Christoph Hellwig
Quoted 8 lines · Lachlan McIlroy
Christoph,
After applying the first round of btree patches we've now got this warning when building a non-debug xfs module.
CC
fs/xfs/xfs_btree.ofs/xfs/xfs_btree.c:191: warning: ?xfs_btree_check_ptr? defined but not used
Quoted 8 lines
Quoted 3 lines
I took a quick look through your next round of btree patches but couldn't see a fix for it. Did I miss something in the original patch set? Is it fixed in a later patch? If not here's a fix:
No, it's not used for now. For some reason I missed the warning.
The patch looks good, can you also put it into xfs-cmds so the two copies stay in sync?
Okay. Thanks.