Skip to contentSkip to conversation

ASoC: Remove references to Endrelia ETI-B1 board

PATCH In review Frank Mandarino 5 participants 11 messages Sep 30, 2008 – Oct 1, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Remove references to Endrelia ETI-B1 board

See attached.

Signature · 3 lines
Frank Mandarino                                fmandarino(a)endrelia.com
Endrelia Technologies Inc.
Toronto, Ontario, Canada

The ASoC machine drivers for this board were only provided as examples for the new AT91 ASoC platform driver. Since the ETI-B1 board is proprietary and there are other AT91 ASoC machine drivers available, it makes sense to remove these drivers.

---
 sound/soc/at91/Kconfig           |   27 ---
 sound/soc/at91/Makefile          |    7 -
 sound/soc/at91/eti_b1_bluecore.c |  284 -------------------------------
 sound/soc/at91/eti_b1_wm8731.c   |  350 --------------------------------------
 4 files changed, 0 insertions(+), 668 deletions(-)
sound/soc/at91/Kconfig +0 -27
index 5bdd98f..85a8832 100644
@@ -8,30 +8,3 @@ config SND_AT91_SOC
 
 config SND_AT91_SOC_SSC
 	tristate
-
-config SND_AT91_SOC_ETI_B1_WM8731
-	tristate "SoC Audio support for WM8731-based Endrelia ETI-B1 boards"
-	depends on SND_AT91_SOC && (MACH_ETI_B1 || MACH_ETI_C1)
-	select SND_AT91_SOC_SSC
-	select SND_SOC_WM8731
-	help
-	  Say Y if you want to add support for SoC audio on WM8731-based
-	  Endrelia Technologies Inc ETI-B1 or ETI-C1 boards.
-
-config SND_AT91_SOC_ETI_SLAVE
-	bool "Run codec in slave Mode on Endrelia boards"
-	depends on SND_AT91_SOC_ETI_B1_WM8731
-	default n
-	help
-	  Say Y if you want to run with the AT91 SSC generating the BCLK
-	  and LRC signals on Endrelia boards.
-
-config SND_AT91_SOC_ETI_B1_BLUECORE
-	tristate "SoC Audio support for BlueCore PCM on Endrelia ETI-B1 boards"
-	depends on SND_AT91_SOC && (MACH_ETI_B1 || MACH_ETI_C1)
-	select SND_AT91_SOC_SSC
-	help
-	  Say Y if you want to add support for SoC audio on the CSR BlueCore
-	  Bluetooth PCM interface on Endrelia Technologies Inc ETI-B1 or
-	  ETI-C1 boards.
-
sound/soc/at91/Makefile +0 -7
index 0003740..b817f11 100644
@@ -4,10 +4,3 @@ snd-soc-at91-ssc-objs := at91-ssc.o
 
 obj-$(CONFIG_SND_AT91_SOC) += snd-soc-at91.o
 obj-$(CONFIG_SND_AT91_SOC_SSC) += snd-soc-at91-ssc.o
-
-# AT91 Machine Support
-snd-soc-eti-b1-wm8731-objs := eti_b1_wm8731.o
-snd-soc-eti-b1-bluecore-objs := eti_b1_bluecore.o
-
-obj-$(CONFIG_SND_AT91_SOC_ETI_B1_WM8731) += snd-soc-eti-b1-wm8731.o
-obj-$(CONFIG_SND_AT91_SOC_ETI_B1_BLUECORE) += snd-soc-eti-b1-bluecore.o
sound/soc/at91/eti_b1_bluecore.c deleted +0 -284

284 lines not on this page · raw message

sound/soc/at91/eti_b1_wm8731.c deleted +0 -350

350 lines not on this page · raw message

Signature · 1 line
1.4.2

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#2 lore raw
In reply to Frank Mandarino

At Tue, 30 Sep 2008 10:42:40 -0400,

Quoted 6 lines · Frank Mandarino

The ASoC machine drivers for this board were only provided as examples for the new AT91 ASoC platform driver. Since the ETI-B1 board is proprietary and there are other AT91 ASoC machine drivers available, it makes sense to remove these drivers.

Quoted 6 lines
---
 sound/soc/at91/Kconfig           |   27 ---
 sound/soc/at91/Makefile          |    7 -
 sound/soc/at91/eti_b1_bluecore.c |  284 -------------------------------
 sound/soc/at91/eti_b1_wm8731.c   |  350 --------------------------------------

Note that eti_b1_bluecore isn't in the current ALSA tree.

thanks,

Takashi

#5 lore raw
In reply to Frank Mandarino
Quoted 1 line · Frank Mandarino

See attached.

I am a bit unclear about the implications of this, when it was first discussed and now there is a definite patch to remove eti_b1_wm8731.c

We based on this file to create an AT91<->wm8731 system; how is it proposed that the codec is glued to the board in the future? Or is most of the code superfluous anyway?

Alan

#7 lore raw
In reply to Frank Mandarino

2008/9/30 Frank Mandarino <[email protected]>

Quoted 21 lines

See attached.

--
Frank Mandarino fmandarino(a)endrelia.com
Endrelia Technologies Inc.
Toronto, Ontario, Canada

The ASoC machine drivers for this board were only provided as examples for the new AT91 ASoC platform driver. Since the ETI-B1 board is proprietary and there are other AT91 ASoC machine drivers available, it makes sense to remove these drivers.

---
 sound/soc/at91/Kconfig           |   27 ---
 sound/soc/at91/Makefile          |    7 -
 sound/soc/at91/eti_b1_bluecore.c |  284 -------------------------------
 sound/soc/at91/eti_b1_wm8731.c   |  350
--------------------------------------
 4 files changed, 0 insertions(+), 668 deletions(-)
Quoted 1 line

Does it make sense to remove these yet? I didn't check different

architectures in asoc-dev but are there any other platform and machine driver using multiple DAI links with real and "dummy" codec in ASoC v1? In that sense these are nice reference implementations :-)

Jarkko

#3 lore raw
In reply to Takashi Iwai
Quoted 14 lines · Takashi Iwai

At Tue, 30 Sep 2008 10:42:40 -0400,

Quoted 11 lines · Frank Mandarino

The ASoC machine drivers for this board were only provided as examples for the new AT91 ASoC platform driver. Since the ETI-B1 board is proprietary and there are other AT91 ASoC machine drivers available, it makes sense to remove these drivers.

---
 sound/soc/at91/Kconfig           |   27 ---
 sound/soc/at91/Makefile          |    7 -
 sound/soc/at91/eti_b1_bluecore.c |  284 -------------------------------
 sound/soc/at91/eti_b1_wm8731.c   |  350 --------------------------------------
Quoted 6 lines

Note that eti_b1_bluecore isn't in the current ALSA tree.

thanks,

Takashi

Yes, I realize this. I created the patch against the dev branch of the ASoC git repository, where eti_b1_bluecore does exist.

Mark: is this a problem? Should I create a patch against the ASoC "master" branch?

../fam

Signature · 4 lines
Frank Mandarino					[email protected]
Endrelia Technologies Inc.
Toronto, Ontario, Canada
416.208.6986 x4522
#6 lore raw
In reply to Alan Horstmann
Quoted 11 lines · Alan Horstmann
Quoted 1 line · Frank Mandarino

See attached.

I am a bit unclear about the implications of this, when it was first discussed and now there is a definite patch to remove eti_b1_wm8731.c

We based on this file to create an AT91<->wm8731 system; how is it proposed that the codec is glued to the board in the future? Or is most of the code superfluous anyway?

Alan

The eti_b1_wm8731.c is the board-specific ASoC machine driver for our proprietary ETI-B1 board. It was only added to the kernel as an example of an AT91 machine driver for others to use when developing a machine driver for their own boards.

ASoC requires you to create your own machine driver to glue the codec to the board. The code is not superfluous.

If you have developed an AT91<->wm8731 board which you are planning to sell, it makes sense to add your machine driver to the kernel so that others can build a kernel for your board. If you are not selling your board, then it probably shouldn't be in the kernel and you should maintain your machine driver privately.

This real issue is that only our company can test ASoC changes against our board, and we don't have always have the resources to do this in a timely fashion. So I would rather not require others who make improvements to ASoC to have to make changes to eti_b1_wm8731.c when they are unable to test them.

Regards,
../fam

Signature · 3 lines
Frank Mandarino                                fmandarino(a)endrelia.com
Endrelia Technologies Inc.
Toronto, Ontario, Canada
#8 lore raw
In reply to Jarkko Nikula
Quoted 26 lines · Jarkko Nikula

2008/9/30 Frank Mandarino <[email protected] <mailto:[email protected]>>

See attached.

--
Frank Mandarino
fmandarino(a)endrelia.com <http://endrelia.com>
Endrelia Technologies Inc.
Toronto, Ontario, Canada

The ASoC machine drivers for this board were only provided as examples for the new AT91 ASoC platform driver. Since the ETI-B1 board is proprietary and there are other AT91 ASoC machine drivers available, it makes sense to remove these drivers.

<mailto:[email protected]>>
---
sound/soc/at91/Kconfig | 27 ---
sound/soc/at91/Makefile | 7 -
sound/soc/at91/eti_b1_bluecore.c | 284 -------------------------------
sound/soc/at91/eti_b1_wm8731.c | 350
--------------------------------------
4 files changed, 0 insertions(+), 668 deletions(-)

Quoted 7 lines

Does it make sense to remove these yet? I didn't check different architectures in asoc-dev but are there any other platform and machine driver using multiple DAI links with real and "dummy" codec in ASoC v1? In that sense these are nice reference implementations :-)

Jarkko

My reasons for wanting it removed are that 1) it only works on our proprietary board, and 2) I don't have time to maintain it as changes are made to ASoC.

If it is still useful for documentation purposes, then perhaps it should be moved to a file in Documentation/sound/alsa/soc. But then again, someone will have maintain the documentation.

Regards,
../fam

Signature · 3 lines
Frank Mandarino                                fmandarino(a)endrelia.com
Endrelia Technologies Inc.
Toronto, Ontario, Canada
#4 lore raw
In reply to Frank Mandarino
Quoted 5 lines · Frank Mandarino

Yes, I realize this. I created the patch against the dev branch of the ASoC git repository, where eti_b1_bluecore does exist.

Mark: is this a problem? Should I create a patch against the ASoC "master" branch?

No, don't worry about it - I'll deal with it.

#9 lore raw
In reply to Frank Mandarino
Quoted 5 lines · Frank Mandarino
Quoted 3 lines · Jarkko Nikula

Does it make sense to remove these yet? I didn't check different architectures in asoc-dev but are there any other platform and machine driver using multiple DAI links with real and "dummy" codec in ASoC v1?

There's also an out of tree Mainstone Bluetooth driver which does the same thing (in the pxa directory in ASoC git).

Quoted 1 line
Quoted 1 line

In that sense these are nice reference implementations :-)

Quite frankly nice isn't the first adjective that springs to my mind for how this stuff works in v1. As with so many other things once v2 is in that should make life better.

Quoted 3 lines

My reasons for wanting it removed are that 1) it only works on our proprietary board, and 2) I don't have time to maintain it as changes are made to ASoC.

I tend to agree with Frank here - if it's causing too much work for the people with access to the hardware and nobody else can get the hardware it's probably as easy to maintain it out of tree. Like I say, there's another public example of this sort of setup.

Ideally someone would contribute a driver for a reasonably available platform that does this - OpenMoko doesn't since they use an analogue connection for their Bluetooth audio.

#10 lore raw
Quoted 9 lines · Mark Brown
Quoted 3 lines · Frank Mandarino
Quoted 1 line · Jarkko Nikula

In that sense these are nice reference implementations :-)

Quite frankly nice isn't the first adjective that springs to my mind for how this stuff works in v1. As with so many other things once v2 is in that should make life better.

Unfortunately it's sometimes have to stick into older stuff :-)

Quoted 9 lines
Quoted 4 lines

My reasons for wanting it removed are that 1) it only works on our proprietary board, and 2) I don't have time to maintain it as changes are made to ASoC.

I tend to agree with Frank here - if it's causing too much work for the people with access to the hardware and nobody else can get the hardware it's probably as easy to maintain it out of tree. Like I say, there's another public example of this sort of setup.

Yeah, valid points. And anyway, this driver can still be found from git history if needed.

Quoted 4 lines

Ideally someone would contribute a driver for a reasonably available platform that does this - OpenMoko doesn't since they use an analogue connection for their Bluetooth audio.

Let's throw a hint here if some hacker is interested that it would be possible with Nokia N810 (and N800 as well) by developing DAI driver for OMAP2420 EAC - Enhanced Audio Controller. EAC has dedicated ports for codec (pins can be muxed to McBSP port 2), modem (not used in N8x0) and bluetooth (pins cannot be muxed to McBSP).

Unfortunately this EAC is found only from OMAP2420 where McBSP is in every OMAP so EAC DAI driver doesn't have so generic use IMO. But I'm keen to help testing and development if someone would do it :-)

Jarkko