em28xx-dvb: dvb_init() code factorization
PATCH 1/1 em28xx-dvb: dvb_init() code factorization
Hello all,
here is a trivial patch that does code factorization between cases in dvb_init() function of the em28xx-dvb component. Is there a reason not to do that?
Cheers,
Thierry
patch description:
In dvb_init(),
case EM2880_BOARD_TERRATEC_HYBRID_XS:
case EM2880_BOARD_KWORLD_DVB_310U:can be put in the same case than EM2880_BOARD_HAUPPAUGE_WINTV_HVR_900 since they do the same thing.
Priority: normal
Signed-off-by Thierry MERLE <[email protected]>
linux/drivers/media/video/em28xx/em28xx-dvb.c +2 -18
@@ -422,6 +422,8 @@ }break ;case EM2880_BOARD_HAUPPAUGE_WINTV_HVR_900 : +case EM2880_BOARD_TERRATEC_HYBRID_XS : +case EM2880_BOARD_KWORLD_DVB_310U : dvb->frontend =dvb_attach (zl10353_attach, &em28xx_zl10353_with_xc3028, &dev->i2c_adap);
@@ -443,24 +445,6 @@ }break ;#endif -case EM2880_BOARD_TERRATEC_HYBRID_XS : - dvb->frontend =dvb_attach (zl10353_attach, - &em28xx_zl10353_with_xc3028, - &dev->i2c_adap); -if (attach_xc3028 (0x61 , dev) <0 ) { - result = -EINVAL ; - goto out_free; - } -break ; -case EM2880_BOARD_KWORLD_DVB_310U : - dvb->frontend =dvb_attach (zl10353_attach, - &em28xx_zl10353_with_xc3028, - &dev->i2c_adap); -if (attach_xc3028 (0x61 , dev) <0 ) { - result = -EINVAL ; - goto out_free; - } -break ;default : printk(KERN_ERR "%s/2: The frontend of your DVB/ATSC card" " isn't supported yet\n",
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list