Skip to contentSkip to conversation

compilation warning for arch/x86/kernel/xsave.c

2.6.27-git2 Rufus & Azrael 2 participants 3 messages Oct 12, 2008 – Oct 13, 2008

lore
Share & tools
lore
#0 lore raw

Hi Suresh,

Your commit ed405958057ca6a8c4c9178a7a3b1167fabb45f5 causes this compilation warning on xsave.c :

Quoted 2 lines

arch/x86/kernel/xsave.c: In function ‘save_i387_xstate’:
arch/x86/kernel/xsave.c:98: attention : ignoring return value of ‘__clear_user’, declared with attribute warn_unused_result

Regards.

#1 lore raw
Quoted 9 lines · Rufus & Azrael

Hi Suresh,

Your commit ed405958057ca6a8c4c9178a7a3b1167fabb45f5 causes this compilation warning on xsave.c :

Quoted 3 lines

arch/x86/kernel/xsave.c: In function ‘save_i387_xstate’:
arch/x86/kernel/xsave.c:98: attention : ignoring return value of ‘__clear_user’, declared with attribute warn_unused_result

Thanks Rufus for the report and thanks Ingo for pushing the fix.

I wonder why CONFIG_ENABLE_MUST_CHECK is not turned on by default? I turned this option on, in the list of configs I use.

thanks,
suresh

#2 lore raw
Quoted 14 lines · Suresh Siddha
Quoted 11 lines · Rufus& Azrael

Hi Suresh,

Your commit ed405958057ca6a8c4c9178a7a3b1167fabb45f5 causes this compilation warning on xsave.c :

Quoted 4 lines

arch/x86/kernel/xsave.c: In function ‘save_i387_xstate’:
arch/x86/kernel/xsave.c:98: attention : ignoring return value of ‘__clear_user’, declared with attribute warn_unused_result

Quoted 9 lines

Thanks Rufus for the report and thanks Ingo for pushing the fix.

I wonder why CONFIG_ENABLE_MUST_CHECK is not turned on by default? I turned this option on, in the list of configs I use.

thanks,
suresh

Hi Suresh,

This option is set to Y in my .config, but I don't remember if it was volontary or by default.

Regards.