release memory regions in PAGES_PER_SECTION chunks
Subsystems (2)
PATCH 1/1 release memory regions in PAGES_PER_SECTION chunks
During hotplug memory remove, memory regions should be released on a PAGES_PER_SECTION size chunks. This mirrors the code in add_memory where resources are requested on a PAGES_PER_SECTION size.
Attempting to release the entire memory region fails because there is not a single resource for the total number of pages being removed. Instead the resources for the pages are split in PAGES_PER_SECTION size chunks as requested during memory add.
---
mm/memory_hotplug.c +0 -0
@@ -323,11 +323,11 @@
BUG_ON(phys_start_pfn & ~PAGE_SECTION_MASK); BUG_ON(nr_pages % PAGES_PER_SECTION);
- release_mem_region(phys_start_pfn << PAGE_SHIFT, nr_pages * PAGE_SIZE);
-
sections_to_remove = nr_pages / PAGES_PER_SECTION;
for (i = 0; i < sections_to_remove; i++) {
unsigned long pfn = phys_start_pfn + i*PAGES_PER_SECTION;
+ release_mem_region(pfn << PAGE_SHIFT,
+ PAGES_PER_SECTION << PAGE_SHIFT);
ret = __remove_section(zone, __pfn_to_section(pfn));
if (ret)
break;Good catch.
Looks good to me.
Quoted 37 lines
During hotplug memory remove, memory regions should be released on a
PAGES_PER_SECTIONsize chunks. This mirrors the code inadd_memorywhere resources are requested on aPAGES_PER_SECTIONsize.Attempting to release the entire memory region fails because there is not a single resource for the total number of pages being removed. Instead the resources for the pages are split in
PAGES_PER_SECTIONsize chunks as requested during memory add.Signed-off-by Nathan Fontenot <[email protected]>Signed-off-by Badari Pulavarty <[email protected]>---
Index:
linux-2.6/mm/memory_hotplug.c
===================================================================mm/memory_hotplug.c +2
-3@@ -323,11 +323,11 @@BUG_ON (phys_start_pfn & ~PAGE_SECTION_MASK );BUG_ON (nr_pages %PAGES_PER_SECTION ); -release_mem_region (phys_start_pfn <<PAGE_SHIFT , nr_pages *PAGE_SIZE ); - sections_to_remove = nr_pages /PAGES_PER_SECTION ;for (i =0 ; i < sections_to_remove; i++) {unsigned long pfn = phys_start_pfn + i*PAGES_PER_SECTION ; +release_mem_region (pfn <<PAGE_SHIFT , +PAGES_PER_SECTION <<PAGE_SHIFT ); ret =__remove_section (zone,__pfn_to_section (pfn));if (ret)break ; --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 1 line
Yasunori Goto