Skip to contentSkip to conversation

gdbstub: remove unused local variable

PATCH Applied Jan Kiszka 3 participants 5 messages Oct 14, 2008

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 gdbstub: remove unused local variable

---
 gdbstub.c |    2 --
 1 file changed, 2 deletions(-)
gdbstub.c +0 -2
Index: b/gdbstub.c
===================================================================
@@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
 #else
     else if (n < 64) {
         /* f0-f31 */
-        uint32_t fpr;
-
         env->fpr[n] = ldfl_p(mem_buf);
         return 4;
     } else if (n < 80) {
#1 lore raw

gdbstub.c static int cpu_gdb_write_register(CPUSta · line 609

Quoted 11 lines · Jan Kiszka
gdbstub.c +0 -2
@@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
 #else
     else if (n < 64) {
         /* f0-f31 */
-        uint32_t fpr;
-
         env->fpr[n] = ldfl_p(mem_buf);
         return 4;
     } else if (n < 80) {

And if somebody wanted to fix that to return 8 instead of 4, that'd be great too. :)

-Nathan

#2 lore raw
Quoted 16 lines · Nathan Froyd

gdbstub.c static int cpu_gdb_write_register(CPUSta · line 609

Quoted 11 lines · Jan Kiszka
gdbstub.c +0 -2
@@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
 #else
     else if (n < 64) {
         /* f0-f31 */
-        uint32_t fpr;
-
         env->fpr[n] = ldfl_p(mem_buf);
         return 4;
     } else if (n < 80) {

And if somebody wanted to fix that to return 8 instead of 4, that'd be great too. :)

What's the rational behind that? AFAIK f0-f31 "registers" are 32-bit "registers", even on SPARC64.

Signature · 4 lines
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   [email protected]         | [email protected]
   `-    people.debian.org/~aurel32 | www.aurel32.net
#3 lore raw
Quoted 7 lines · Aurelien Jarno
Quoted 3 lines · Nathan Froyd

And if somebody wanted to fix that to return 8 instead of 4, that'd be great too. :)

What's the rational behind that? AFAIK f0-f31 "registers" are 32-bit "registers", even on SPARC64.

Sorry, wrong CPU. I didn't look at the wider context, my mistake.

-Nathan

#4 lore raw
In reply to Jan Kiszka

Thanks, applied.

Quoted 21 lines · Jan Kiszka
---
 gdbstub.c |    2 --
 1 file changed, 2 deletions(-)

Index: b/gdbstub.c
===================================================================

gdbstub.c +0 -2
@@ -604,8 +604,6 @@ static int cpu_gdb_write_register(CPUSta
 #else
     else if (n < 64) {
         /* f0-f31 */
-        uint32_t fpr;
-
         env->fpr[n] = ldfl_p(mem_buf);
         return 4;
     } else if (n < 80) {
Signature · 4 lines
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   [email protected]         | [email protected]
   `-    people.debian.org/~aurel32 | www.aurel32.net