mgcoge: correct init of the UPIOx
Signed-off-by Heiko Schocher <[email protected]>
--- board/keymile/mgcoge/mgcoge.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
board/keymile/mgcoge/mgcoge.c +1 -1
@@ -296,7 +296,7 @@ int board_early_init_r (void) {/* setup the UPIOx */ *(char *)(CFG_PIGGY_BASE +0x02 ) =0xc0 ; - *(char *)(CFG_PIGGY_BASE +0x03 ) =0x15 ; + *(char *)(CFG_PIGGY_BASE +0x03 ) =0x35 ;return 0 ; }
Signature · 5 lines
1.5.6.1 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Dear Heiko Schocher,
Quoted 10 lines · In message <[email protected]> you wrote:
Signed-off-by Heiko Schocher <[email protected]>--- board/keymile/mgcoge/mgcoge.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)board/keymile/mgcoge/mgcoge.c +0
-0
board/keymile/mgcoge/mgcoge.c int board_early_init_r (void) · line 301
Quoted 7 lines
board/keymile/mgcoge/mgcoge.c +1
-1@@ -296,7 +296,7 @@ int board_early_init_r (void) {/* setup the UPIOx */ *(char *)(CFG_PIGGY_BASE +0x02 ) =0xc0 ; - *(char *)(CFG_PIGGY_BASE +0x03 ) =0x15 ; + *(char *)(CFG_PIGGY_BASE +0x03 ) =0x35 ;return 0 ; }
Umm... no.
Please change all this code to use the appropriate accesor functions instead (these pointers are not even volatile - shudder...).
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The more we disagree, the more chance there is that at least one of us is right.