mgcoge, mgsuvd: cleanups
mgcoge: Second Flash on CS5
use in_*/out_* accessors
mgsuvd: fix Codingstyle issues
use in_*/out_* accessors
Signed-off-by Heiko Schocher <[email protected]>
---
This Patch replaces the Patches:
http://lists.denx.de/pipermail/u-boot/2008-October/041881.html
[U-Boot] [POWERPC] mgcoge: correct init of the UPIOx
http://lists.denx.de/pipermail/u-boot/2008-October/041892.html
[U-Boot] [POWERPC] mgcoge: Second Flash on CS5 not on CS1
board/keymile/mgcoge/mgcoge.c | 9 +++-- board/keymile/mgsuvd/mgsuvd.c | 73 ++++++++++++++++++---------------------- 2 files changed, 39 insertions(+), 43 deletions(-)
board/keymile/mgcoge/mgcoge.c +6 -3
@@ -25,6 +25,7 @@#include <mpc8260.h> #include <ioports.h> #include <malloc.h> +#include <asm/io.h> #if defined(CONFIG_OF_BOARD_SETUP ) && defined(CONFIG_OF_LIBFDT )#include <libfdt.h>
@@ -295,8 +296,10 @@ int checkboard(void)int board_early_init_r (void ) {/* setup the UPIOx */ - *(char *)(CONFIG_SYS_PIGGY_BASE +0x02 ) =0xc0 ; - *(char *)(CONFIG_SYS_PIGGY_BASE +0x03 ) =0x15 ; +out_8 ((volatile unsigned char __iomem *) + (CONFIG_SYS_PIGGY_BASE +0x02 ),0xc0 ); +out_8 ((volatile unsigned char __iomem *) + (CONFIG_SYS_PIGGY_BASE +0x03 ),0x15 );return 0 ; }
@@ -334,7 +337,7 @@ void ft_blob_update (void *blob, bd_t *bd)/* update Flash addr, size */ flash_data[2 ] =cpu_to_be32 (CONFIG_SYS_FLASH_BASE ); flash_data[3 ] =cpu_to_be32 (CONFIG_SYS_FLASH_SIZE ); - flash_data[4 ] =cpu_to_be32 (1 ); + flash_data[4 ] =cpu_to_be32 (5 ); flash_data[5 ] =cpu_to_be32 (0 ); flash_data[6 ] =cpu_to_be32 (CONFIG_SYS_FLASH_BASE_1 ); flash_data[7 ] =cpu_to_be32 (CONFIG_SYS_FLASH_SIZE_1 );
board/keymile/mgsuvd/mgsuvd.c +33 -40
132 lines not on this page · raw message
Signature · 5 lines
1.5.6.1 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Dear Heiko Schocher,
Quoted 4 lines · In message <[email protected]> you wrote:
mgcoge: Second Flash on CS5
use in_*/out_* accessors
mgsuvd: fix Codingstyle issues
use in_*/out_* accessors
Please split into separate patches: one for the CS5, second for the coding style fixes, and a third for the change to use in_*/out_* accessors
Thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
C++ was an interesting and valuable experiment, but we've learned its
lessons and it's time to move on.
- Peter Curran in <[email protected]>