Skip to contentSkip to conversation

Fix debugfs_create_*'s error checking method for mips/math-emu/

PATCH Applied Zhaolei 2 participants 3 messages Oct 17, 2008 MIPS

lore
Share & tools
lore

Zhaolei

author
#0 lore raw

PATCH 1/1 Fix debugfs_create_*'s error checking method for mips/math-emu/

Hi,

debugfs_create_*() returns NULL if an error occurs, returns -ENODEV when debugfs is not enabled in the kernel.

Signed-off-by Zhao Lei <[email protected]>
---
 arch/mips/math-emu/cp1emu.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
arch/mips/math-emu/cp1emu.c +4 -4
index b08fc65..7ec0b21 100644
@@ -1299,12 +1299,12 @@ static int __init debugfs_fpuemu(void)
 	if (!mips_debugfs_dir)
 		return -ENODEV;
 	dir = debugfs_create_dir("fpuemustats", mips_debugfs_dir);
-	if (IS_ERR(dir))
-		return PTR_ERR(dir);
+	if (!dir)
+		return -ENOMEM;
 	for (i = 0; i < ARRAY_SIZE(vars); i++) {
 		d = debugfs_create_u32(vars[i].name, S_IRUGO, dir, vars[i].v);
-		if (IS_ERR(d))
-			return PTR_ERR(d);
+		if (!d)
+			return -ENOMEM;
 	}
 	return 0;
 }
Signature · 1 line
1.5.5.3
Applied
#1 lore raw
Quoted 2 lines · Zhaolei

debugfs_create_*() returns NULL if an error occurs, returns -ENODEV when debugfs is not enabled in the kernel.

Thanks, applied.

Ralf

Applied
#2 lore raw
In reply to Zhaolei
Quoted 2 lines · Zhaolei

debugfs_create_*() returns NULL if an error occurs, returns -ENODEV when debugfs is not enabled in the kernel.

Thanks, applied.

Ralf