Don't unmap the memory for dma_sync*.
PATCH 1/1 Don't unmap the memory for dma_sync*.
Don't unmap the memory for dma_sync*.
This must have been typo, it cannot have been correct.
Signed-off-by David Daney <[email protected]>
---arch/mips/mm/dma-default.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
arch/mips/mm/dma-default.c +0 -0
@@ -324,7 +324,6 @@ void dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nelems,
if (cpu_is_noncoherent_r10000(dev)) __dma_sync((unsigned long)page_address(sg_page(sg)), sg->length, direction); - plat_unmap_dma_mem(sg->dma_address); } }
@@ -342,7 +341,6 @@ void dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg, int nele
if (!plat_device_is_coherent(dev)) __dma_sync((unsigned long)page_address(sg_page(sg)), sg->length, direction); - plat_unmap_dma_mem(sg->dma_address); } }
Quoted 3 lines · David Daney
Don't unmap the memory for dma_sync*.
This must have been typo, it cannot have been correct.
Interesting ...
We were getting away with this for so long only because the only platform (Jazz) with a non-empty plat_unmap_dma_mem() doesn't call dma_sync_sg_for_cpu() and dma_sync_sg_for_device() from its commonly used drivers.
Ralf