Skip to contentSkip to conversation

libata: initialize port_task when !CONFIG_ATA_SFF

PATCH Applied Tejun Heo 2 participants 2 messages Oct 20, 2008 – Oct 23, 2008 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: initialize port_task when !CONFIG_ATA_SFF

Subject: libata: initialize port_task when !CONFIG_ATA_SFF

ap->port_task was not initialized if !CONFIG_ATA_SFF later triggering lockdep warning. Make sure it's initialized.

Reported by Larry Finger.

Signed-off-by Tejun Heo <[email protected]>
Cc Larry Finger <[email protected]>
---
 drivers/ata/libata-core.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/ata/libata-core.c +2 -0
Index: work/drivers/ata/libata-core.c
===================================================================
@@ -5373,6 +5373,8 @@ struct ata_port *ata_port_alloc(struct a
 
 #ifdef CONFIG_ATA_SFF
 	INIT_DELAYED_WORK(&ap->port_task, ata_pio_task);
+#else
+	INIT_DELAYED_WORK(&ap->port_task, NULL);
 #endif
 	INIT_DELAYED_WORK(&ap->hotplug_task, ata_scsi_hotplug);
 	INIT_WORK(&ap->scsi_rescan_task, ata_scsi_dev_rescan);
Applied
#1 lore raw
Quoted 5 lines · Tejun Heo

Subject: libata: initialize port_task when !CONFIG_ATA_SFF

ap->port_task was not initialized if !CONFIG_ATA_SFF later triggering lockdep warning. Make sure it's initialized.

Quoted 7 lines

Reported by Larry Finger.

Signed-off-by Tejun Heo <[email protected]>
Cc Larry Finger <[email protected]>
---
 drivers/ata/libata-core.c |    2 ++
 1 file changed, 2 insertions(+)

applied