Skip to contentSkip to conversation

Problem booting wireless-testing 2.6.28-rc1

PATCH Larry Finger 2 participants 2 messages Oct 25, 2008 libata

lore
Share & tools
lore
#0 lore raw

If you download and boot 2.6.28-rc1 from wireless-testing, you may have a problem in the boot process finding your hard drive. The fix has been found in mainline and consists of the following patch:

commit e013e13bf605b9e6b702adffbe2853cfc60e7806

Author: Jens Axboe <[email protected]>
Date:   Fri Oct 24 09:22:42 2008 +0200

libata: fix bug with non-ncq devices

The recent commit 2fca5ccf97d2c28bcfce44f5b07d85e74e3cd18e ("libata:
switch to using block layer tagging support") to enable support for block layer tagging in libata was broken for non-NCQ devices

The block layer initializes the tag field to -1 to detect invalid uses of a tag, and if the libata devices does NOT support NCQ, we just used that field to index the internal command list. So we need to check for -1 first and only use the tag field if it's valid.

drivers/ata/libata-scsi.c +0 -0
index d5b9b72..4b95c43 100644
@@ -708,7 +708,11 @@ static struct ata_queued_cmd *ata_scsi_qc_new(struct

ata_device *dev,
{
struct ata_queued_cmd *qc;

- qc = ata_qc_new_init(dev, cmd->request->tag);
+ if (cmd->request->tag != -1)
+ qc = ata_qc_new_init(dev, cmd->request->tag);
+ else
+ qc = ata_qc_new_init(dev, 0);
+
if (qc) {
qc->scsicmd = cmd;
qc->scsidone = done;

Larry

#1 lore raw
Quoted 9 lines · Larry Finger

If you download and boot 2.6.28-rc1 from wireless-testing, you may have a problem in the boot process finding your hard drive. The fix has been found in mainline and consists of the following patch:

commit e013e13bf605b9e6b702adffbe2853cfc60e7806

Author: Jens Axboe <[email protected]>
Date:   Fri Oct 24 09:22:42 2008 +0200

libata: fix bug with non-ncq devices

Thanks for the heads-up! This is now part of wireless-testing's master branch.

John

Signature · 2 lines
John W. Linville		Linux should be at the core
[email protected]			of your literate lifestyle.