Skip to contentSkip to conversation

xfstest: confirm mkfs.gfs[2] in test 032

PATCH Superseded Eric Sandeen 2 participants 3 messages Nov 1, 2008 – Nov 12, 2008

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 xfstest: confirm mkfs.gfs[2] in test 032

mkfs.gfs[2] asks for confirmation before mkfs'ing; without this test 032 hangs when mkfs.gfs2 is present.

Signed-off-by Eric Sandeen <[email protected]>

---

xfstests/032 +2 -0
Index: xfs-cmds/xfstests/032
===================================================================
@@ -43,6 +43,8 @@ do
 	[ $fs = vfat ] && postargs=2000
 	# these folks prompt before writing
 	[ $fs = jfs ] && preop="echo Y |"
+	[ $fs = gfs ] && preop="echo y |"
+	[ $fs = gfs2 ] && preop="echo y |"
 	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
 	# cramfs mkfs requires a directory argument
 	[ $fs = cramfs ] && preargs=/proc/fs/xfs
author
#1 lore raw

PATCH v2 1/1 xfstest: confirm mkfs.gfs[2] in test 032

mkfs.gfs[2] asks for confirmation before mkfs'ing; without this test 032 hangs when mkfs.gfs2 is present.

Also, mkfs.gfs needs a few more args to make it go.

Signed-off-by Eric Sandeen <[email protected]>

---

xfstests/032 +2 -0
Index: xfs-cmds/xfstests/032
===================================================================
@@ -43,6 +43,8 @@ do
 	[ $fs = vfat ] && postargs=2000
 	# these folks prompt before writing
 	[ $fs = jfs ] && preop="echo Y |"
+	[ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
+	[ $fs = gfs2 ] && preop="echo y |"
 	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
 	# cramfs mkfs requires a directory argument
 	[ $fs = cramfs ] && preargs=/proc/fs/xfs
#2 lore raw
Quoted 4 lines · Eric Sandeen

mkfs.gfs[2] asks for confirmation before mkfs'ing; without this test 032 hangs when mkfs.gfs2 is present.

Also, mkfs.gfs needs a few more args to make it go.

Looks good.