common/cmd_ide.c: Corrected endian order printing for compact flash serial number.
PATCH 1/1 common/cmd_ide.c: Corrected endian order printing for compact flash serial number.
Corrected endian order printing for compact flash serial number.
--- common/cmd_ide.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
common/cmd_ide.c +4 -3
@@ -1166,15 +1166,16 @@ static void ide_ident (block_dev_desc_t *dev_desc)ident_cpy ((unsigned char *)dev_desc->product, iop->serial_no,sizeof (dev_desc->product));#ifdef __LITTLE_ENDIAN/* -* firmware revision and model number have Big Endian Byte -* order in Word. Convert both to little endian. +* firmware revision, model, and serial number have Big Endian Byte +* order in Word. Convert all three to little endian. * * See CF+ and CompactFlash Specification Revision 2.0: -* 6.2.1.6: Identfy Drive, Table 39 for more details +* 6.2.1.6: Identify Drive, Table 39 for more details */ strswab (dev_desc->revision);strswab (dev_desc->vendor); +strswab (dev_desc->product);#endif /* __LITTLE_ENDIAN */ if ((iop->config &0x0080 )==0x0080 )
Signature · 1 line
1.5.5.GIT
PATCH 1/1 common/cmd_ide.c: Corrected endian order printing for compact flash serial number.
Hi Wolfgang,
By no means is this a critical patch, I'm just a bit obsessive about tying up loose ends (or patches) Is there a custodian I should ping for feedback on this patch, or are you it?
Thanks for your time
- Richard
Quoted 31 lines · Richard Retanubun
Corrected endian order printing for compact flash serial number.
Signed-off-by Richard Retanubun <[email protected]>--- common/cmd_ide.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)common/cmd_ide.c +4
-3@@ -1166,15 +1166,16 @@ static void ide_ident (block_dev_desc_t *dev_desc)ident_cpy ((unsigned char *)dev_desc->product, iop->serial_no,sizeof (dev_desc->product));#ifdef __LITTLE_ENDIAN/* -* firmware revision and model number have Big Endian Byte -* order in Word. Convert both to little endian. +* firmware revision, model, and serial number have Big Endian Byte +* order in Word. Convert all three to little endian. * * See CF+ and CompactFlash Specification Revision 2.0: -* 6.2.1.6: Identfy Drive, Table 39 for more details +* 6.2.1.6: Identify Drive, Table 39 for more details */ strswab (dev_desc->revision);strswab (dev_desc->vendor); +strswab (dev_desc->product);#endif /* __LITTLE_ENDIAN */ if ((iop->config &0x0080 )==0x0080 )
Wolfgang Denk
AppliedPATCH 1/1 common/cmd_ide.c: Corrected endian order printing for compact flash serial number.
In reply to Richard RetanubunDear Richard Retanubun,
Quoted 6 lines · In message <[email protected]> you wrote:
Corrected endian order printing for compact flash serial number.
Signed-off-by Richard Retanubun <[email protected]>--- common/cmd_ide.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The ideal situation is to have massive computing power right at home. Something that dims the streetlights and shrinks the picture on the neighbours' TVs when you boot it up.