Skip to contentSkip to conversation

Reserve elfcorehdr memory in CONFIG_CRASH_DUMP

PATCH In review Jay Lan 2 participants 2 messages Nov 7, 2008

Subsystems (2)
Live update kexec handover (KHO)
lore
Share & tools
lore

Jay Lan

author
#0 lore raw

PATCH 1/1 Reserve elfcorehdr memory in CONFIG_CRASH_DUMP

IA64 kdump kernel failed to initialize /proc/vmcore in 2.6.28-rc2. A bug was introduced in this patch commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d9a9855d0b06ca6d6cc92596fedcc03f8512e062

The problem was that the call to reserve_elfcorehdr() should be placed in CONFIG_CRASH_DUMP rather than in CONFIG_CRASH_KERNEL, which does not exist.

The patch fixes the problem.

Signed-off-by Jay Lan <[email protected]>
---
 arch/ia64/kernel/setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/setup.c +1 -1
Index: linux/arch/ia64/kernel/setup.c
===================================================================
@@ -359,7 +359,7 @@ reserve_memory (void)
 	}
 #endif
 
-#ifdef CONFIG_CRASH_KERNEL
+#ifdef CONFIG_CRASH_DUMP
 	if (reserve_elfcorehdr(&rsvd_region[n].start,
 			       &rsvd_region[n].end) == 0)
 		n++;
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Jay Lan

IA64 kdump kernel failed to initialize /proc/vmcore in 2.6.28-rc2. A bug was introduced in this patch commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;hÙa9855d0b06ca6d6cc92596fedcc03f8512e062

The problem was that the call to reserve_elfcorehdr() should be placed in CONFIG_CRASH_DUMP rather than in CONFIG_CRASH_KERNEL, which does not exist.

The patch fixes the problem.

Signed-off-by Jay Lan <[email protected]>
Acked-by Simon Horman <[email protected]>
Quoted 16 lines
---
 arch/ia64/kernel/setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/arch/ia64/kernel/setup.c
=================================> --- linux.orig/arch/ia64/kernel/setup.c 2008-11-06 18:01:18.000000000 -0800
+++ linux/arch/ia64/kernel/setup.c 2008-11-06 18:05:42.047332827 -0800

arch/ia64/kernel/setup.c +1 -1
@@ -359,7 +359,7 @@ reserve_memory (void)
 	}
 #endif
 
-#ifdef CONFIG_CRASH_KERNEL
+#ifdef CONFIG_CRASH_DUMP
 	if (reserve_elfcorehdr(&rsvd_region[n].start,
 			       &rsvd_region[n].end) = 0)
 		n++;
Signature · 3 lines
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en