Skip to contentSkip to conversation

review: xfstests/192 atime test

DISCUSSION Timothy Shimmin 2 participants 5 messages Nov 11, 2008 – Dec 8, 2008

lore
Share & tools
lore
#0 lore raw

Attached simple atime test.
192.out and group file would be added appropriately. Thanks.
--Tim

#! /bin/sh
# FS QA Test No. 192
#
# Simple test of atime - ensure it is persistent after unmount #
#-----------------------------------------------------------------------
# Copyright (c) 2008 Silicon Graphics, Inc. All Rights Reserved.
#-----------------------------------------------------------------------
#

# creator
[email protected]

seq=basename $0
echo "QA output created by $seq"

here=pwd
tmp=/tmp/$$
status=1 # failure is the default!
trap "exit \$status" 0 1 2 3 15

_access_time()

{
	stat --format=%X $1
}
# get standard environment, filters and checks
. ./common.rc
. ./common.filter
# real QA test starts here

_supported_fs xfs udf nfs
_supported_os Linux
delay=150

testfile=$TEST_DIR/testfile
rm -f $testfile
rm -f $seq.full

echo test >$testfile
time1=_access_time $testfile | tee -a $seq.full

echo "sleep for $delay"
sleep $delay # sleep to allow time to move on for access cat $testfile
time2=_access_time $testfile | tee -a $seq.full

cd /
umount $TEST_DIR
mount $TEST_DIR
time3=_access_time $testfile | tee -a $seq.full

delta1=expr $time2 - $time1
delta2=expr $time3 - $time1

echo "delta1 - access time after sleep in-core: $delta1" echo "delta2 - access time after sleep on-disk: $delta2"

# success, all done
status=0
exit

#1 lore raw
Quoted 8 lines · Timothy Shimmin

Attached simple atime test.
192.out and group file would be added appropriately. Thanks.
--Tim

_supported_fs xfs udf nfs
_supported_os Linux
delay=150

150s sleep? It only needs a few seconds for this test.

Quoted 7 lines

time3=_access_time $testfile | tee -a $seq.full

delta1=expr $time2 - $time1
delta2=expr $time3 - $time1

echo "delta1 - access time after sleep in-core: $delta1" echo "delta2 - access time after sleep on-disk: $delta2"

Why bother with deltas? if the numbers are the same, just output "same", if they are different, output "different"....

FWIW, is there a patch being proposed that fixes this problem?

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#2 lore raw
Quoted 6 lines · Dave Chinner
Quoted 4 lines · Timothy Shimmin

Attached simple atime test.
192.out and group file would be added appropriately. Thanks.
--Tim

Quoted 6 lines
Quoted 3 lines

_supported_fs xfs udf nfs
_supported_os Linux
delay=150

150s sleep? It only needs a few seconds for this test.

Not for me. Passed every time at a few secs, that is why I tried longer as was originally reported.

Quoted 11 lines
Quoted 7 lines

time3=_access_time $testfile | tee -a $seq.full

delta1=expr $time2 - $time1
delta2=expr $time3 - $time1

echo "delta1 - access time after sleep in-core: $delta1" echo "delta2 - access time after sleep on-disk: $delta2"

Why bother with deltas? if the numbers are the same, just output "same", if they are different, output "different"....

Fine, will do.

Quoted 2 lines

FWIW, is there a patch being proposed that fixes this problem?

I lost the thread with people to'ing and fro'ing ;-) I'd have to relook at the last emails.

--Tim

#3 lore raw
Quoted 19 lines · Timothy Shimmin
Quoted 10 lines · Dave Chinner
Quoted 7 lines · Timothy Shimmin

Attached simple atime test.
192.out and group file would be added appropriately. Thanks.
--Tim
_supported_fs xfs udf nfs
_supported_os Linux
delay=150

150s sleep? It only needs a few seconds for this test.

Not for me. Passed every time at a few secs, that is why I tried longer as was originally reported.

Quoted 5 lines
Quoted 5 lines

time3=_access_time $testfile | tee -a $seq.full

delta1=expr $time2 - $time1
delta2=expr $time3 - $time1

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

echo "delta1 - access time after sleep in-core: $delta1" echo "delta2 - access time after sleep on-disk: $delta2"

Why bother with deltas? if the numbers are the same, just output "same", if they are different, output "different"....

Fine, will do.

The only other thing is that I am not just testing the bug as it stands - i.e. if the atime is being lost on-disk. I want to test that the atime is updated appropriately.

--Tim

#4 lore raw
Quoted 25 lines · Timothy Shimmin
Quoted 24 lines · Timothy Shimmin
Quoted 10 lines · Dave Chinner
Quoted 7 lines · Timothy Shimmin

Attached simple atime test.
192.out and group file would be added appropriately. Thanks.
--Tim
_supported_fs xfs udf nfs
_supported_os Linux
delay=150

150s sleep? It only needs a few seconds for this test.

Not for me. Passed every time at a few secs, that is why I tried longer as was originally reported.

Quoted 10 lines
Quoted 7 lines

time3=_access_time $testfile | tee -a $seq.full

delta1=expr $time2 - $time1
delta2=expr $time3 - $time1

echo "delta1 - access time after sleep in-core: $delta1" echo "delta2 - access time after sleep on-disk: $delta2"

Why bother with deltas? if the numbers are the same, just output "same", if they are different, output "different"....

Quoted 8 lines
Quoted 2 lines

Fine, will do.

The only other thing is that I am not just testing the bug as it stands - i.e. if the atime is being lost on-disk. I want to test that the atime is updated appropriately.

--Tim

Ping?
Not fussed?

Thanks,
--Tim

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs