Skip to contentSkip to conversation

usb: r8a66597-hcd: fix wrong data access in SuperH on-chip USB

PATCH In review Yoshihiro Shimoda 2 participants 2 messages Nov 11, 2008 – Nov 13, 2008

Subsystems (2)
USB SuperH
lore
Share & tools
lore

Yoshihiro Shimoda

author
#0 lore raw

PATCH 1/1 usb: r8a66597-hcd: fix wrong data access in SuperH on-chip USB

When I used SuperH on-chip USB, there was the problem that accessed r8a66597_root_hub which was not allocated.

Signed-off-by Yoshihiro Shimoda <[email protected]>
---
 drivers/usb/host/r8a66597-hcd.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/usb/host/r8a66597-hcd.c +3 -2
index c18d879..2376f24 100644
@@ -1763,11 +1763,12 @@ static void r8a66597_timer(unsigned long _r8a66597)
 {
 	struct r8a66597 *r8a66597 = (struct r8a66597 *)_r8a66597;
 	unsigned long flags;
+	int port;
 
 	spin_lock_irqsave(&r8a66597->lock, flags);
 
-	r8a66597_root_hub_control(r8a66597, 0);
-	r8a66597_root_hub_control(r8a66597, 1);
+	for (port = 0; port < R8A66597_MAX_ROOT_HUB; port++)
+		r8a66597_root_hub_control(r8a66597, port);
 
 	spin_unlock_irqrestore(&r8a66597->lock, flags);
 }
Signature · 1 line
1.5.5
#1 lore raw
Quoted 4 lines · Yoshihiro Shimoda

When I used SuperH on-chip USB, there was the problem that accessed r8a66597_root_hub which was not allocated.

Signed-off-by Yoshihiro Shimoda <[email protected]>

I've applied this also for 2.6.28, I'll send it out with the rest of the updates later today, thanks.