Question about IPMI password MAX length test in openbmc-test-automation
Hi Anusha,
I met an issue that "Verify Setting IPMI User With Invalid Password Length" will fail when its user id is same as "Verify Setting IPMI User With Max Password Length".
This is because the password length 20 has been successfully set in "Verify Setting IPMI User With Max Password Length". Therefore, the case of password_length = 21 and password_option = 20 is expected to fail but pass when their user id are the same.
I have two solutions:
1. Only verify the message that cannot use invalid password length to set password and do not verify that user is able to run IPMI command with given username and password in this case.
2. At the end of each case, delete the user it just created to ensure that it will not affect other cases.
Which is better, or do you have other suggestions?
Thanks
Best Regards,
Tony
Hi Tony,
I would say option 2 is better. There is no need to verify IPMI command execution when set user password is expected to fail.
Thanks
Rahul
Quoted 28 lines · Tony Lee (李文富)
Hi Anusha,
I met an issue that "Verify Setting IPMI User With Invalid Password Length" will fail when
its user id is same as "Verify Setting IPMI User With Max Password Length".This is because the password length 20 has been successfully set in "Verify Setting IPMI User With Max Password Length". Therefore, the case of
password_length= 21 andpassword_option= 20 is expected to fail but pass when their user id are the same.I have two solutions:
1. Only verify the message that cannot use invalid password length to set password
and do not verify that user is able to run IPMI command with given username and password in this case.2. At the end of each case, delete the user it just created to ensure that it will not affect other cases.
Which is better, or do you have other suggestions?
Thanks
Best Regards,
Tony
Hi Tony, I have removed the login verification for cases where password is not set. Added you as a reviewer for the code.
Thanks & Regards
Anusha Dathatri,
Power Firmware,
Email: [email protected]
Mobile : 9916920803 ----- Original message -----
From: Rahul Maheshwari <[email protected]>
To: "Tony Lee (李文富)" <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: [EXTERNAL] Re: Question about IPMI password MAX length test in openbmc-test-automation
Date: Tue, Jan 7, 2020 12:36 PM
oops .. I meat to say option 1 is better. Typo mistake from my side. On Tue, Jan 7, 2020 at 12:19 PM Tony Lee (李文富) <[email protected]> wrote: Hi Rahul,
Thank you for your reply.
I'm confused, you said that option 2 is better but the additional explanation is about option 1.
Thanks
Best Regards,
Tony
From:Rahul Maheshwari <[email protected]>
Sent:Tuesday, January 7, 2020 1:45 PM
To:Tony Lee (李文富) <[email protected]>
Cc: [email protected]; [email protected]
Subject:Re: Question about IPMI password MAX length test in openbmc-test-automation
Hi Tony,
I would say option 2 is better. There is no need to verify IPMI command execution when set user password is expected to fail.
Thanks
Rahul
On Mon, Jan 6, 2020 at 3:06 PM Tony Lee (李文富) <[email protected]> wrote:
Hi Anusha,
I met an issue that "Verify Setting IPMI User With Invalid Password Length" will fail when its user id is same as "Verify Setting IPMI User With Max Password Length".
This is because the password length 20 has been successfully set in "Verify Setting IPMI User With Max Password Length". Therefore, the case of password_length = 21 and password_option = 20 is expected to fail but pass when their user id are the same.
I have two solutions:
1. Only verify the message that cannot use invalid password length to set password and do not verify that user is able to run IPMI command with given username and password in this case.
2. At the end of each case, delete the user it just created to ensure that it will not affect other cases.
Which is better, or do you have other suggestions?
Thanks
Best Regards,
Tony