mfd: Fix define values of CS1_HIB_MODE.
Subsystems (2)
PATCH 1/1 mfd: Fix define values of CS1_HIB_MODE.
Hi Mark,
I found a little mistake.
The define values are wrong.
It is written in the WM8350 DATA SHEET Rev 3.4 P285 that CS1_HIB_MODE(bit 12) is disable at "1".
The following is it.
<WM8350 DATA SHEET Rev 3.4 P285>
REGISTER |BIT| LABEL | DESCRIPTION
ADDRESS | | |
---------+---+------------+-------------
R172(ACh)| 12|CS1_HIB_MODE| 0=leave current sink as in Active
| | | 1=disable current shik in HibemateCould you please check the following patch ?
Regards,
Naohiro Ooiwa
--- include/linux/mfd/wm8350/pmic.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/mfd/wm8350/pmic.h +2 -2
@@ -83,8 +83,8 @@#define WM8350_CS1_ISEL_SHIFT 0/* Bit values for R172 (0xAC) */ -#define WM8350_CS1_HIB_MODE_DISABLE 0 -#define WM8350_CS1_HIB_MODE_LEAVE 1 +#define WM8350_CS1_HIB_MODE_DISABLE 1 +#define WM8350_CS1_HIB_MODE_LEAVE 0#define WM8350_CS1_ISEL_220M 0x3F
Signature · 1 line
1.5.4.1
Quoted 5 lines · Naohiro Ooiwa
I found a little mistake.
The define values are wrong.It is written in the WM8350 DATA SHEET Rev 3.4 P285 that
CS1_HIB_MODE(bit 12)is disable at "1".
I will double check but I believe this to be a datasheet error - if it is it will be corrected in the datasheet.
Hi Mark,
I'm sorry for this late reply.
I checked the WM8350 DATA SHEET Rev 4.0 P287.
It's already corrected.
Thank you for your work.
Regards,
Naohiro Ooiwa
Mark Brown wrote::
Quoted 11 lines · Naohiro Ooiwa
Quoted 6 lines
I found a little mistake.
The define values are wrong.It is written in the WM8350 DATA SHEET Rev 3.4 P285 that
CS1_HIB_MODE(bit 12)is disable at "1".I will double check but I believe this to be a datasheet error - if it is it will be corrected in the datasheet.