sctp: Avoid memory overflow while FWD-TSN chunk is received with
Subsystems (2)
If FWD-TSN chunk is received with bad stream ID, the sctp will not do the validity check, this may cause memory overflow when overwrite the TSN of the stream ID.
The FORWARD-TSN chunk is like this:
FORWARD-TSN chunk
Type = 192 Flags = 0 Length = 172 NewTSN = 99 Stream = 10000 StreamSequence = 0xFFFF
This patch fix this problem by skip the stream ID which not less than MIS.
--- net/sctp/ulpqueue.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
net/sctp/ulpqueue.c +4 -1
@@ -940,7 +940,10 @@ void sctp_ulpq_skip(struct sctp_ulpq *ulpq, __u16 sid, __u16 ssn) {struct sctp_stream *in; -/* Note: The stream ID must be verified before this routine. */ +/* Skip the stream ID which larger than MIS */ +if (sid >= ulpq->asoc->c.sinit_max_instreams) +return ; + in = &ulpq->asoc->ssnmap->in;/* Is this an old SSN? If so ignore. */
Signature · 1 line
1.6.0.2.530.g67faa
Quoted 27 lines · Wei Yongjun
If FWD-TSN chunk is received with bad stream ID, the sctp will not do the validity check, this may cause memory overflow when overwrite the TSN of the stream ID.
The FORWARD-TSN chunk is like this:
FORWARD-TSN chunk
Type = 192 Flags = 0 Length = 172 NewTSN = 99 Stream = 10000 StreamSequence = 0xFFFFThis patch fix this problem by skip the stream ID which not less than MIS.
Signed-off-by Wei Yongjun <[email protected]>--- net/sctp/ulpqueue.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)net/sctp/ulpqueue.c +0
-0@@ -940,7 +940,10 @@ void sctp_ulpq_skip(struct sctp_ulpq *ulpq, __u16 sid, __u16 ssn) {
net/sctp/ulpqueue.c void sctp_ulpq_skip(struct sctp_ulpq *ulpq, __u16 sid, __u16 ssn) · line 949
Quoted 10 lines
net/sctp/ulpqueue.c +4
-1struct sctp_stream *in; -/* Note: The stream ID must be verified before this routine. */ +/* Skip the stream ID which larger than MIS */ +if (sid >= ulpq->asoc->c.sinit_max_instreams) +return ; + in = &ulpq->asoc->ssnmap->in;/* Is this an old SSN? If so ignore. */
Yes, this check is needed, but this is the wrong place. Should we really process the FWD-TSN if the stream-id is invalid? My opinion would be NO.
So, the check and stream-id walk is really needed in sctp_sf_eat_fwd_tsn() and sctp_sf_eat_fwd_tsn_fast() and we can simply discard the chunk treating it just like if the TSN is invalid.
-vlad