fix similar typos to successfull, v2
Subsystems (25)
PATCH 1/1 fix similar typos to successfull, v2
When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull " in kernel tree, 22 typos found totally -- great minds always think alike :)
This patch fixes all the similar typos. Thanks for Randy's ack and comments.
Signed-off-by Coly Li <[email protected]>
Cc Randy Dunlap <[email protected]>
--- Documentation/hwmon/abituguru-datasheet | 4 ++-- Documentation/scsi/scsi_fc_transport.txt | 4 ++-- arch/powerpc/platforms/cell/spufs/spufs.h | 2 +- drivers/infiniband/hw/nes/nes_cm.c | 2 +- drivers/isdn/hardware/eicon/debuglib.h | 2 +- drivers/isdn/hardware/eicon/os_4bri.c | 2 +- drivers/isdn/hardware/eicon/os_bri.c | 2 +- drivers/isdn/hardware/eicon/os_pri.c | 2 +- drivers/mtd/ubi/kapi.c | 2 +- drivers/net/wireless/ath5k/dma.c | 2 +- drivers/net/wireless/zd1211rw/zd_mac.c | 2 +- drivers/s390/block/dasd_3990_erp.c | 2 +- drivers/s390/block/dasd_int.h | 2 +- drivers/s390/char/tape_3590.c | 2 +- drivers/s390/cio/cio.c | 2 +- drivers/s390/cio/qdio_main.c | 2 +- fs/ext4/extents.c | 2 +- fs/ocfs2/dlmglue.c | 4 ++-- net/sctp/auth.c | 2 +- 19 files changed, 22 insertions(+), 22 deletions(-)
Documentation/hwmon/abituguru-datasheet +2 -2
@@ -121,7 +121,7 @@ Once all bytes have been read data will hold 0x09, but there is no reason to test for this. Notice that the number of bytes is bank address dependent see above and below. -After completing a successfull read it is advised to put the uGuru back in +After completing a successful read it is advised to put the uGuru back in ready mode, so that it is ready for the next read / write cycle. This way if your program / driver is unloaded and later loaded again the detection algorithm described above will still work.
@@ -141,7 +141,7 @@ don't ask why this is the way it is. Once DATA holds 0x01 read CMD it should hold 0xAC now. -After completing a successfull write it is advised to put the uGuru back in +After completing a successful write it is advised to put the uGuru back in ready mode, so that it is ready for the next read / write cycle. This way if your program / driver is unloaded and later loaded again the detection algorithm described above will still work.
Documentation/scsi/scsi_fc_transport.txt +2 -2
@@ -191,7 +191,7 @@ Vport States: This is equivalent to a driver "attach" on an adapter, which is independent of the adapter's link state. - Instantiation of the vport on the FC link via ELS traffic, etc. - This is equivalent to a "link up" and successfull link initialization. + This is equivalent to a "link up" and successful link initialization. Further information can be found in the interfaces section below for Vport Creation.
@@ -320,7 +320,7 @@ Vport Creation: This is equivalent to a driver "attach" on an adapter, which is independent of the adapter's link state. - Instantiation of the vport on the FC link via ELS traffic, etc. - This is equivalent to a "link up" and successfull link initialization. + This is equivalent to a "link up" and successful link initialization. The LLDD's vport_create() function will not synchronously wait for both parts to be fully completed before returning. It must validate that the
arch/powerpc/platforms/cell/spufs/spufs.h +1 -1
@@ -314,7 +314,7 @@ extern char *isolated_loader;* we need to call spu_release(ctx) before sleeping, and * then spu_acquire(ctx) when awoken. * -* Returns with state_mutex re-acquired when successfull or +* Returns with state_mutex re-acquired when successful or * with -ERESTARTSYS and the state_mutex dropped when interrupted. */
drivers/infiniband/hw/nes/nes_cm.c +1 -1
@@ -2717,7 +2717,7 @@ int nes_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) attr.qp_state =IB_QPS_RTS ;nes_modify_qp (&nesqp->ibqp, &attr,IB_QP_STATE ,NULL ); -/* notify OF layer that accept event was successfull */ +/* notify OF layer that accept event was successful */ cm_id->add_ref (cm_id); cm_event.event =IW_CM_EVENT_ESTABLISHED ;
drivers/isdn/hardware/eicon/debuglib.h +1 -1
@@ -235,7 +235,7 @@ typedef void ( * DbgOld) (unsigned short, char *, va_list) ;typedef void ( *DbgEv ) (unsigned short ,unsigned long ,va_list ) ;typedef void ( *DbgIrq ) (unsigned short ,int ,char *,va_list ) ; typedef struct _DbgHandle_ -{ char Registered ; /* driver successfull registered */ +{ char Registered ; /* driver successfully registered */ #define DBG_HANDLE_REG_NEW 0x01 /* this (new) structure */ #define DBG_HANDLE_REG_OLD 0x7f /* old structure (see below) */ char Version; /* version of this structure */
drivers/isdn/hardware/eicon/os_4bri.c +1 -1
@@ -997,7 +997,7 @@ diva_4bri_start_adapter(PISDN_ADAPTER IoAdapter,diva_xdi_display_adapter_features (IoAdapter->ANum);for (i =0 ; i < IoAdapter->tasks; i++) { -DBG_LOG (("A(%d) %s adapter successfull started" , +DBG_LOG (("A(%d) %s adapter successfully started" , IoAdapter->QuadroList->QuadroAdapter[i]->ANum, (IoAdapter->tasks == 1) ? "BRI 2.0" : "4BRI"))diva_xdi_didd_register_adapter (IoAdapter->QuadroList->QuadroAdapter[i]->ANum);
drivers/isdn/hardware/eicon/os_bri.c +1 -1
@@ -736,7 +736,7 @@ diva_bri_start_adapter(PISDN_ADAPTER IoAdapter, IoAdapter->Properties.Features = (word ) features;diva_xdi_display_adapter_features (IoAdapter->ANum); -DBG_LOG (("A(%d) BRI adapter successfull started" , IoAdapter->ANum)) +DBG_LOG (("A(%d) BRI adapter successfully started" , IoAdapter->ANum))/* Register with DIDD */
drivers/isdn/hardware/eicon/os_pri.c +1 -1
@@ -513,7 +513,7 @@ diva_pri_start_adapter(PISDN_ADAPTER IoAdapter,diva_xdi_display_adapter_features (IoAdapter->ANum); -DBG_LOG (("A(%d) PRI adapter successfull started" , IoAdapter->ANum)) +DBG_LOG (("A(%d) PRI adapter successfully started" , IoAdapter->ANum))/* Register with DIDD */
drivers/mtd/ubi/kapi.c +1 -1
@@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(ubi_leb_unmap);* @dtype: expected data type * * This function maps an un-mapped logical eraseblock @lnum to a physical -* eraseblock. This means, that after a successfull invocation of this +* eraseblock. This means, that after a successful invocation of this * function the logical eraseblock @lnum will be empty (contain only %0xFF * bytes) and be mapped to a physical eraseblock, even if an unclean reboot * happens.
drivers/net/wireless/ath5k/dma.c +1 -1
@@ -530,7 +530,7 @@ int ath5k_hw_get_isr(struct ath5k_hw *ah, enum ath5k_int *interrupt_mask)* XXX: BMISS interrupts may occur after association. * I found this on 5210 code but it needs testing. If this is * true we should disable them before assoc and re-enable them -* after a successfull assoc + some jiffies. +* after a successful assoc + some jiffies. */ #if 0 interrupt_mask &= ~AR5K_INT_BMISS ;
drivers/net/wireless/zd1211rw/zd_mac.c +1 -1
@@ -287,7 +287,7 @@ static void zd_op_stop(struct ieee80211_hw *hw)* @skb - a sk-buffer * @flags: extra flags to set in the TX status info * @ackssi: ACK signal strength -* @success - True for successfull transmission of the frame +* @success - True for successful transmission of the frame * * This information calls ieee80211_tx_status_irqsafe() if required by the * control information. It copies the control information into the status
drivers/s390/block/dasd_3990_erp.c +1 -1
@@ -2621,7 +2621,7 @@ dasd_3990_erp_action(struct dasd_ccw_req * cqr) } } -/* double-check if current erp/cqr was successfull */ +/* double-check if current erp/cqr was successful */ if ((cqr->irb.scsw.cmd.cstat ==0x00 ) && (cqr->irb.scsw.cmd.dstat == (DEV_STAT_CHN_END |DEV_STAT_DEV_END ))) {
drivers/s390/block/dasd_int.h +1 -1
@@ -199,7 +199,7 @@ struct dasd_ccw_req {#define DASD_CQR_ERROR 0x82/* request is completed with error */ #define DASD_CQR_CLEAR_PENDING 0x83/* request is clear pending */ #define DASD_CQR_CLEARED 0x84/* request was cleared */ -#define DASD_CQR_SUCCESS 0x85/* request was successfull */ +#define DASD_CQR_SUCCESS 0x85/* request was successful */ /* per dasd_ccw_req flags */
drivers/s390/char/tape_3590.c +1 -1
@@ -801,7 +801,7 @@ tape_3590_done(struct tape_device *device, struct tape_request *request)static inline int tape_3590_erp_succeded (struct tape_device *device,struct tape_request *request) { -DBF_EVENT (3 ,"Error Recovery successfull for %s\n" , +DBF_EVENT (3 ,"Error Recovery successful for %s\n" , tape_op_verbose[request->op]);return tape_3590_done (device, request); }
drivers/s390/cio/cio.c +1 -1
@@ -380,7 +380,7 @@ cio_modify (struct subchannel *sch)if (ccode <0 )/* -EIO if msch gets a program check. */ return ccode;switch (ccode) { -case 0 :/* successfull */ +case 0 :/* successful */ return 0 ;case 1 :/* status pending */ return -EBUSY ;
drivers/s390/cio/qdio_main.c +1 -1
@@ -116,7 +116,7 @@ static inline int qdio_check_ccq(struct qdio_q *q, unsigned int ccq)* @start: buffer number to start at * @count: count of buffers to examine * -* Returns the number of successfull extracted equal buffer states. +* Returns the number of successfully extracted equal buffer states. * Stops processing if a state is different from the last buffers state. */ static int qdio_do_eqbs(struct qdio_q *q, unsigned char *state,
fs/ext4/extents.c +1 -1
@@ -2536,7 +2536,7 @@ static int ext4_ext_convert_to_initialized(handle_t *handle,*/ newdepth =ext_depth (inode);/* -* update the extent length after successfull insert of the +* update the extent length after successful insert of the * split extent */ orig_ex.ee_len = cpu_to_le16(ee_len -
fs/ocfs2/dlmglue.c +2 -2
@@ -1290,7 +1290,7 @@ again: goto out; } -mlog (0 ,"lock %s, successfull return from ocfs2_dlm_lock\n" , +mlog (0 ,"lock %s, successful return from ocfs2_dlm_lock\n" , lockres->l_name);/* At this point we've gone inside the dlm and need to
@@ -2923,7 +2923,7 @@ static int ocfs2_drop_lock(struct ocfs2_super *osb,ocfs2_dlm_dump_lksb (&lockres->l_lksb);BUG (); } -mlog (0 ,"lock %s, successfull return from ocfs2_dlm_unlock\n" , +mlog (0 ,"lock %s, successful return from ocfs2_dlm_unlock\n" , lockres->l_name);ocfs2_wait_on_busy_lock (lockres);
net/sctp/auth.c +1 -1
@@ -489,7 +489,7 @@ int sctp_auth_init_hmacs(struct sctp_endpoint *ep, gfp_t gfp)return 0 ; out_err: -/* Clean up any successfull allocations */ +/* Clean up any successful allocations */ sctp_auth_destroy_hmacs (ep->auth_hmacs);return -ENOMEM ; }
Signature · 2 lines
Coly Li SuSE PRC Labs
Quoted 7 lines · Coly Li
When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull " in kernel tree, 22 typos found totally -- great minds always think alike :)
This patch fixes all the similar typos. Thanks for Randy's ack and comments.
Signed-off-by Coly Li <[email protected]>Cc Randy Dunlap <[email protected]>
Acked-by Randy Dunlap <[email protected]>
Thanks.
Quoted 2 lines · On Tue, 25 Nov 2008 01:44:13 +0800 Coly Li <[email protected]> wrote:
When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull " in kernel tree, 22 typos found totally -- great minds always think alike :)
Mutter. I have a super-strict (lol) policy of "I don't take patches which fix typos/spellos in comments", because we have so many such errors, and I'd get buried in silly patches. But I do take patches which fix documentation and user-visible printks, etc.
Quoted 11 lines
Documentation/hwmon/abituguru-datasheet | 4 ++-- Documentation/scsi/scsi_fc_transport.txt | 4 ++-- arch/powerpc/platforms/cell/spufs/spufs.h | 2 +- drivers/infiniband/hw/nes/nes_cm.c | 2 +- drivers/isdn/hardware/eicon/debuglib.h | 2 +- drivers/isdn/hardware/eicon/os_4bri.c | 2 +- drivers/isdn/hardware/eicon/os_bri.c | 2 +- drivers/isdn/hardware/eicon/os_pri.c | 2 +- drivers/mtd/ubi/kapi.c | 2 +- drivers/net/wireless/ath5k/dma.c | 2 +- drivers/net/wireless/zd1211rw/zd_mac.c | 2 +-
Quoted 8 lines
drivers/s390/block/dasd_3990_erp.c | 2 +- drivers/s390/block/dasd_int.h | 2 +- drivers/s390/char/tape_3590.c | 2 +- drivers/s390/cio/cio.c | 2 +- drivers/s390/cio/qdio_main.c | 2 +- fs/ext4/extents.c | 2 +- fs/ocfs2/dlmglue.c | 4 ++-- net/sctp/auth.c | 2 +-
This patch sneakily mixed the two up, so I merged it ;)
Quoted 10 lines · Andrew Morton
Quoted 2 lines · On Tue, 25 Nov 2008 01:44:13 +0800 Coly Li <[email protected]> wrote:
When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull " in kernel tree, 22 typos found totally -- great minds always think alike :)
Mutter. I have a super-strict (lol) policy of "I don't take patches which fix typos/spellos in comments", because we have so many such errors, and I'd get buried in silly patches. But I do take patches which fix documentation and user-visible printks, etc.
Since you started the thread, I feel less guilty to talk about the existence of tons of another kind of typo spread around the kernel
sources: null statements created by duplicated semi-colons at the end of statements. Something like foo();;
Cheers,
Fernando
Quoted 12 lines · On Tue, 25 Nov 2008 21:49:13 -0200 Fernando Carrijo <[email protected]>…
Quoted 10 lines · Andrew Morton
Quoted 2 lines · On Tue, 25 Nov 2008 01:44:13 +0800 Coly Li <[email protected]> wrote:
When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull " in kernel tree, 22 typos found totally -- great minds always think alike :)
Mutter. I have a super-strict (lol) policy of "I don't take patches which fix typos/spellos in comments", because we have so many such errors, and I'd get buried in silly patches. But I do take patches which fix documentation and user-visible printks, etc.
Quoted 4 lines
Since you started the thread, I feel less guilty to talk about the existence of tons of another kind of typo spread around the kernel
sources: null statements created by duplicated semi-colons at the end of statements. Something likefoo();;
We should just fix those.
Quoted 1 line · Andrew Morton
We should just fix those.
Just in case "we" mean "me", here goes patch. Since this is my second post in the list, I suspect the format may not be what you expect. In that case, I'll be more than happy to try again.
Fernando
Quoted 1 line
From
1c7e713664690abd73b8ea08f63ea854549221a4Mon Sep 17 00:00:00 2001
From: Fernando Carrijo <[email protected]>
Date: Tue, 25 Nov 2008 22:31:31 -0200
Subject: [PATCH] Removal of unnecessary null statements.
--- arch/x86/kernel/cpu/cpufreq/longhaul.c | 2 +- arch/x86/kernel/ptrace.c | 2 +- fs/ext4/mballoc.c | 4 ++-- fs/namespace.c | 2 +- fs/ocfs2/alloc.c | 2 +- fs/ocfs2/file.c | 2 +- net/ipv6/route.c | 2 +- net/ipv6/sysctl_net_ipv6.c | 2 +- net/sched/sch_sfq.c | 2 +- security/smack/smackfs.c | 2 +- sound/soc/au1x/dbdma2.c | 2 +- sound/soc/davinci/davinci-pcm.c | 2 +- 12 files changed, 13 insertions(+), 13 deletions(-)
arch/x86/kernel/cpu/cpufreq/longhaul.c +1 -1
@@ -982,7 +982,7 @@ static int __init longhaul_init(void)case 10 : printk(KERN_ERR PFX "Use acpi-cpufreq driver for VIA C7\n");default : - ;; + ; }return -ENODEV ;
arch/x86/kernel/ptrace.c +1 -1
@@ -637,7 +637,7 @@ static inline unsigned long bts_get(const char *base, enum bts_field field)static inline void bts_set (char *base,enum bts_field field,unsigned long val) { - base += (bts_cfg.sizeof_field * field);; + base += (bts_cfg.sizeof_field * field); (*(unsigned long *)base) = val; }
fs/ext4/mballoc.c +2 -2
@@ -2086,7 +2086,7 @@ static void *ext4_mb_seq_groups_next(struct seq_file *seq, void *v, loff_t *pos)if (*pos <0 || *pos >= sbi->s_groups_count)return NULL ; group = *pos +1 ; -return (void *) group;; +return (void *) group; }static int ext4_mb_seq_groups_show (struct seq_file *seq,void *v)
@@ -2300,7 +2300,7 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, }INIT_LIST_HEAD (&meta_group_info[i]->bb_prealloc_list); - meta_group_info[i]->bb_free_root.rb_node =NULL ;; + meta_group_info[i]->bb_free_root.rb_node =NULL ;#ifdef DOUBLE_CHECK {
fs/namespace.c +1 -1
@@ -1990,7 +1990,7 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns,if (!new_ns->root) {up_write (&namespace_sem);kfree (new_ns); -return ERR_PTR (-ENOMEM );; +return ERR_PTR (-ENOMEM ); }spin_lock (&vfsmount_lock);list_add_tail (&new_ns->list, &new_ns->root->mnt_list);
fs/ocfs2/alloc.c +1 -1
@@ -3781,7 +3781,7 @@ static void ocfs2_split_record(struct inode *inode,struct ocfs2_extent_list *left_el =NULL , *right_el, *insert_el, *el;struct ocfs2_extent_rec *rec, *tmprec; - right_el =path_leaf_el (right_path);; + right_el =path_leaf_el (right_path);if (left_path) left_el =path_leaf_el (left_path);
fs/ocfs2/file.c +1 -1
@@ -1622,7 +1622,7 @@ int ocfs2_change_file_space(struct file *file, unsigned int cmd, struct ocfs2_space_resv *sr) {struct inode *inode = file->f_path.dentry->d_inode; -struct ocfs2_super *osb =OCFS2_SB (inode->i_sb);; +struct ocfs2_super *osb =OCFS2_SB (inode->i_sb);if ((cmd ==OCFS2_IOC_RESVSP || cmd ==OCFS2_IOC_RESVSP64 ) && !ocfs2_writes_unwritten_extents (osb))
net/ipv6/route.c +1 -1
@@ -2715,7 +2715,7 @@ int __init ip6_route_init(void)kmem_cache_create ("ip6_dst_cache" ,sizeof (struct rt6_info ),0 ,SLAB_HWCACHE_ALIGN ,NULL );if (!ip6_dst_ops_template.kmem_cachep) - goto out;; + goto out; ret =register_pernet_subsys (&ip6_route_net_ops);if (ret)
net/ipv6/sysctl_net_ipv6.c +1 -1
@@ -128,7 +128,7 @@ static struct ctl_table_header *ip6_header;int ipv6_sysctl_register (void ) { -int err = -ENOMEM ;; +int err = -ENOMEM ; ip6_header =register_net_sysctl_rotable (net_ipv6_ctl_path, ipv6_table);if (ip6_header ==NULL )
net/sched/sch_sfq.c +1 -1
@@ -486,7 +486,7 @@ static int sfq_init(struct Qdisc *sch, struct nlattr *opt)int i; q->perturb_timer.function = sfq_perturbation; - q->perturb_timer.data = (unsigned long )sch;; + q->perturb_timer.data = (unsigned long )sch;init_timer_deferrable (&q->perturb_timer);for (i =0 ; i <SFQ_HASH_DIVISOR ; i++)
security/smack/smackfs.c +1 -1
@@ -531,7 +531,7 @@ static ssize_t smk_write_cipso(struct file *file, const char __user *buf,if (skp ==NULL ) goto out; - rule +=SMK_LABELLEN ;; + rule +=SMK_LABELLEN ; ret =sscanf (rule,"%d" , &maplevel);if (ret !=1 || maplevel >SMACK_CIPSO_MAXLEVEL ) goto out;
sound/soc/au1x/dbdma2.c +1 -1
@@ -187,7 +187,7 @@ static int au1x_pcm_dbdma_realloc(struct au1xpsc_audio_dmadata *pcd, au1x_pcm_dmatx_cb, (void *)pcd);if (!pcd->ddma_chan) -return -ENOMEM ;; +return -ENOMEM ;au1xxx_dbdma_set_devwidth (pcd->ddma_chan, msbits);au1xxx_dbdma_ring_alloc (pcd->ddma_chan,2 );
sound/soc/davinci/davinci-pcm.c +1 -1
@@ -218,7 +218,7 @@ davinci_pcm_pointer(struct snd_pcm_substream *substream)if (substream->stream ==SNDRV_PCM_STREAM_PLAYBACK ) count = src - runtime->dma_addr;else - count = dst - runtime->dma_addr;; + count = dst - runtime->dma_addr;spin_unlock (&prtd->lock);
Signature · 1 line
1.5.6.3
Andrew Morton Wrote:
Quoted 11 lines
Quoted 2 lines · On Tue, 25 Nov 2008 01:44:13 +0800 Coly Li <[email protected]> wrote:
When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull " in kernel tree, 22 typos found totally -- great minds always think alike :)
Mutter. I have a super-strict (lol) policy of "I don't take patches which fix typos/spellos in comments", because we have so many such errors, and I'd get buried in silly patches. But I do take patches which fix documentation and user-visible printks, etc.
The first time I know this policy, remember it now ;)
Quoted 20 lines
Quoted 11 lines
Documentation/hwmon/abituguru-datasheet | 4 ++-- Documentation/scsi/scsi_fc_transport.txt | 4 ++-- arch/powerpc/platforms/cell/spufs/spufs.h | 2 +- drivers/infiniband/hw/nes/nes_cm.c | 2 +- drivers/isdn/hardware/eicon/debuglib.h | 2 +- drivers/isdn/hardware/eicon/os_4bri.c | 2 +- drivers/isdn/hardware/eicon/os_bri.c | 2 +- drivers/isdn/hardware/eicon/os_pri.c | 2 +- drivers/mtd/ubi/kapi.c | 2 +- drivers/net/wireless/ath5k/dma.c | 2 +- drivers/net/wireless/zd1211rw/zd_mac.c | 2 +-Quoted 8 lines
drivers/s390/block/dasd_3990_erp.c | 2 +- drivers/s390/block/dasd_int.h | 2 +- drivers/s390/char/tape_3590.c | 2 +- drivers/s390/cio/cio.c | 2 +- drivers/s390/cio/qdio_main.c | 2 +- fs/ext4/extents.c | 2 +- fs/ocfs2/dlmglue.c | 4 ++-- net/sctp/auth.c | 2 +-
Quoted 1 line
This patch sneakily mixed the two up, so I merged it ;)
grep does not understand difference between code and comments ;)
I am not 100% agreed that leaving typos/spellos in comments is a proper policy. Anyway, thanks for the effort to merge this patch, it's impossible for me to put so many maintainers into Cc list :)
Signature · 2 lines
Coly Li SuSE PRC Labs