Cablestar 2 i2c retries
PATCH 1/1 Cablestar 2 i2c retries
Hello.
At some point the Flexcop driver was changed to support newer Flexcop cards. These modifications however broke the detection of Cablestar 2 DVB-C cards.
The reason is that the earlier version of the driver used to retry unsuccessful i2c operations. The demodulator of Cablestar 2 cards (stv0297) seems to be very dependent on these retries and adding them back fixes Cablestar detection.
linux/drivers/media/dvb/b2c2/flexcop-fe-tuner.c +2 -0
@@ -628,12 +628,14 @@ }/* try the cable dvb (stv0297) */ + fc->fc_i2c_adap[0 ].no_base_addr =1 ; fc->fe =dvb_attach (stv0297_attach, &alps_tdee4_stv0297_config, i2c);if (fc->fe !=NULL ) { fc->dev_type =FC_CABLE ; fc->fe->ops.tuner_ops.set_params = alps_tdee4_stv0297_tuner_set_params; goto fe_found; } + fc->fc_i2c_adap[0 ].no_base_addr =0 ;/* try the sky v2.3 (vp310/Samsung tbdu18132(tsa5059)) */ fc->fe = dvb_attach(mt312_attach,
linux/drivers/media/dvb/b2c2/flexcop-i2c.c +5 -1
@@ -47,8 +47,12 @@int len = r100.tw_sm_c_100.total_bytes,/* remember total_bytes is buflen-1 */ ret; - r100.tw_sm_c_100.no_base_addr_ack_error = i2c->no_base_addr; ret =flexcop_i2c_operation (i2c->fc, &r100); +if (ret !=0 ) { +deb_i2c ("Retrying operation\n" ); + r100.tw_sm_c_100.no_base_addr_ack_error = i2c->no_base_addr; + ret =flexcop_i2c_operation (i2c->fc, &r100); + }if (ret !=0 ) {deb_i2c ("read failed. %d\n" , ret);return ret;
_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Hi Antti,
Quoted 1 line · Antti Seppälä
The reason is that the earlier version of the driver used to retry unsuccessful i2c operations. The demodulator of Cablestar 2 cards (stv0297) seems to be very dependent on these retries and adding them back fixes Cablestar detection.
Thanks a lot for your fix.
It is committed and asked to be pulled.
Patrick.
--
Mail: [email protected]
WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/
_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb