V4L/DVB (7725): cx23885: unsigned cx23417_mailbox cannot be negative

PATCH New roel kluin 1 participant 1 message Nov 26, 2008 Media (V4L/DVB)

lore

Share & tools

lore

roel kluin

author

2008-11-26 22:03 UTC #0 lore raw

PATCH 1/1 V4L/DVB (7725): cx23885: unsigned cx23417_mailbox cannot be negative

Unsigned cx23417_mailbox cannot be negative

Signed-off-by Roel Kluin <[email protected]>

---
dev->cx23417_mailbox has type u32, see
vi drivers/media/video/cx23885/cx23885.h +330

cx23885_find_mailbox() returns int, see
vi drivers/media/video/cx23885/cx23885-417.c +832

drivers/media/video/cx23885/cx23885-417.c +3 -2

index 8118091..f0f09aa 100644
@@ -1028,12 +1028,13 @@ static int cx23885_initialize_codec(struct cx23885_dev *dev)
 			printk(KERN_ERR "%s() f/w load failed\n", __func__);
 			return retval;
 		}
-		dev->cx23417_mailbox = cx23885_find_mailbox(dev);
-		if (dev->cx23417_mailbox < 0) {
+		retval = cx23885_find_mailbox(dev);
+		if (retval < 0) {
 			printk(KERN_ERR "%s() mailbox < 0, error\n",
 				__func__);
 			return -1;
 		}
+		dev->cx23417_mailbox = retval;
 		retval = cx23885_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0);
 		if (retval < 0) {
 			printk(KERN_ERR