Skip to contentSkip to conversation

hysdn: Kill directly reference of netdev->priv

PATCH Applied Wang Chen 2 participants 2 messages Dec 1, 2008 – Dec 3, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Wang Chen

author
#0 lore raw

PATCH 1/1 hysdn: Kill directly reference of netdev->priv

Usually, netdev->priv should point to the memory of private data which is allocated in alloc_netdev(). netdev_priv() is used to get the address of the private data.

Change the netdev->priv pointer to another memory is wrong. Use netdev->ml_priv for this case.

Signed-off-by Wang Chen <[email protected]>
---
 drivers/isdn/hysdn/hysdn_net.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/isdn/hysdn/hysdn_net.c +3 -3
index cfa8fa5..5b4ae67 100644
@@ -76,7 +76,7 @@ static int
 net_open(struct net_device *dev)
 {
 	struct in_device *in_dev;
-	hysdn_card *card = dev->priv;
+	hysdn_card *card = dev->ml_priv;
 	int i;
 
 	netif_start_queue(dev);	/* start tx-queueing */

@@ -159,7 +159,7 @@ net_send_packet(struct sk_buff *skb, struct net_device *dev)
 	spin_unlock_irq(&lp->lock);
 
 	if (lp->sk_count <= 3) {
-		schedule_work(&((hysdn_card *) dev->priv)->irq_queue);
+		schedule_work(&((hysdn_card *) dev->ml_priv)->irq_queue);
 	}
 	return (0);		/* success */
 }				/* net_send_packet */

@@ -295,7 +295,7 @@ hysdn_net_create(hysdn_card * card)
 		kfree(dev);
 		return (i);
 	}
-	dev->priv = card;	/* remember pointer to own data structure */
+	dev->ml_priv = card;	/* remember pointer to own data structure */
 	card->netif = dev;	/* setup the local pointer */
 
 	if (card->debug_flags & LOG_NET_INIT)
Signature · 1 line
1.5.3.4
maintainer Applied
#1 lore raw

From: Wang Chen <[email protected]>
Date: Mon, 01 Dec 2008 22:28:10 +0800

Quoted 8 lines

Usually, netdev->priv should point to the memory of private data which is allocated in alloc_netdev(). netdev_priv() is used to get the address of the private data.

Change the netdev->priv pointer to another memory is wrong. Use netdev->ml_priv for this case.

Signed-off-by Wang Chen <[email protected]>

Applied.