Skip to contentSkip to conversation

be more verbose when probing EDD

RFC PATCH [email protected] 1 participant 1 message Dec 16, 2007

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

This is awfully verbose.

yes, this was meant as an example
also mind, that the last printf with "\rOK...." is meant to overwrite the hint message, so nobody should ever notice that message. i`m just unsure if this is a good approach. i have found two occurences in linux kernel, where drivers do something similar.

Quoted 1 line

[or even "failed"...]

yes, but how to detect if we got stuck forever inside that bios probe ?
i assume thats hard to do, so thats why i`m printing that hint "into the future", to be overwritten on successful return.

Quoted 2 lines

Also, you really should look for the "quiet" command-line option and squelch the message.

sure! will add that if there is some positive feedback and someone finds this patch useful.

regards
roland

Quoted 26 lines

-----Ursprüngliche Nachricht-----
Von: "H. Peter Anvin" <[email protected]>
Gesendet: 16.12.07 19:17:40
An: [email protected]
CC: [email protected], [email protected]
Betreff: Re: [PATCH] [RFC] be more verbose when probing EDD

Review

Quoted 8 lines · [email protected] wrote:
        /* Query EDD information */

#if defined(CONFIG_EDD) || defined(CONFIG_EDD_MODULE)

(quoted diff) +4 -1
-       query_edd();
+        printf("Probing EDD (query Bios for boot-device information)\n");
+        printf("If boot hangs here, you may have a buggy Bios. Try edd=skipmbr or edd=off");
+        query_edd();
+        printf("\rOK                                                                       \n");
 #endif

This is awfully verbose.

I'd prefer something like:

printf("Probing EDD BIOS... ");
query_edd();
printf("ok\n");

Quoted 7 lines

[or even "failed"...]

Also, you really should look for the "quiet" command-line option and squelch the message.

-hpa

_______________________________________________________________________
Jetzt neu! Schützen Sie Ihren PC mit McAfee und WEB.DE. 3 Monate kostenlos testen. http://www.pc-sicherheit.web.de/startseite/?mc=022220