Skip to contentSkip to conversation

ring_buffer: remove unused ring_buffer size

PATCH Applied Lai Jiangshan 2 participants 2 messages Dec 17, 2008 – Dec 18, 2008

Subsystems (2)
Tracing Tracing ring buffer
lore
Share & tools
lore

Lai Jiangshan

author
#0 lore raw

PATCH 1/1 ring_buffer: remove unused ring_buffer size

struct ring_buffer.size is not set after ring_buffer is initialized or resized. it is always 0.

we can use "buffer->pages * BUF_PAGE_SIZE" to get ring_buffer's size

Signed-off-by Lai Jiangshan <[email protected]>

---

kernel/trace/ring_buffer.c +1 -3
index 668bbb5..7c7ec06 100644
@@ -202,7 +202,6 @@ struct ring_buffer_per_cpu {
 };
 
 struct ring_buffer {
-	unsigned long			size;
 	unsigned			pages;
 	unsigned			flags;
 	int				cpus;

@@ -2090,8 +2089,7 @@ int ring_buffer_swap_cpu(struct ring_buffer *buffer_a,
 		return -EINVAL;
 
 	/* At least make sure the two buffers are somewhat the same */
-	if (buffer_a->size != buffer_b->size ||
-	    buffer_a->pages != buffer_b->pages)
+	if (buffer_a->pages != buffer_b->pages)
 		return -EINVAL;
 
 	cpu_buffer_a = buffer_a->buffers[cpu];
Applied
#1 lore raw
Quoted 6 lines · Lai Jiangshan

struct ring_buffer.size is not set after ring_buffer is initialized or resized. it is always 0.

we can use "buffer->pages * BUF_PAGE_SIZE" to get ring_buffer's size

Signed-off-by Lai Jiangshan <[email protected]>

applied to tip/tracing/ring-buffer, thanks!

Ingo