Skip to contentSkip to conversation

hda: fix incorrect mixer index values for 92hd83xx

PATCH In review Matthew Ranostay 2 participants 3 messages Dec 20, 2008

lore
Share & tools
lore

Matthew Ranostay

author
#0 lore raw

PATCH 1/1 hda: fix incorrect mixer index values for 92hd83xx

Fixed incorrect mixer index values for 92hd83xx codec's audio input mixer.

Signed-off-by Matthew Ranostay <[email protected]>

---

pci/hda/patch_sigmatel.c +10 -10
index 70181d5..efa1fb0 100644
@@ -1101,21 +1101,21 @@ static struct snd_kcontrol_new stac92hd83xxx_mixer[] = {
 	HDA_CODEC_VOLUME_IDX("Capture Volume", 0x1, 0x18, 0x0, HDA_OUTPUT),
 	HDA_CODEC_MUTE_IDX("Capture Switch", 0x1, 0x18, 0x0, HDA_OUTPUT),
 
-	HDA_CODEC_VOLUME("DAC0 Capture Volume", 0x1b, 0, HDA_INPUT),
-	HDA_CODEC_MUTE("DAC0 Capture Switch", 0x1b, 0, HDA_INPUT),
+	HDA_CODEC_VOLUME("DAC0 Capture Volume", 0x1b, 0x3, HDA_INPUT),
+	HDA_CODEC_MUTE("DAC0 Capture Switch", 0x1b, 0x3, HDA_INPUT),
 
-	HDA_CODEC_VOLUME("DAC1 Capture Volume", 0x1b, 0x1, HDA_INPUT),
-	HDA_CODEC_MUTE("DAC1 Capture Switch", 0x1b, 0x1, HDA_INPUT),
+	HDA_CODEC_VOLUME("DAC1 Capture Volume", 0x1b, 0x4, HDA_INPUT),
+	HDA_CODEC_MUTE("DAC1 Capture Switch", 0x1b, 0x4, HDA_INPUT),
 
-	HDA_CODEC_VOLUME("Front Mic Capture Volume", 0x1b, 0x2, HDA_INPUT),
-	HDA_CODEC_MUTE("Front Mic Capture Switch", 0x1b, 0x2, HDA_INPUT),
+	HDA_CODEC_VOLUME("Front Mic Capture Volume", 0x1b, 0x0, HDA_INPUT),
+	HDA_CODEC_MUTE("Front Mic Capture Switch", 0x1b, 0x0, HDA_INPUT),
 
-	HDA_CODEC_VOLUME("Line In Capture Volume", 0x1b, 0x3, HDA_INPUT),
-	HDA_CODEC_MUTE("Line In Capture Switch", 0x1b, 0x3, HDA_INPUT),
+	HDA_CODEC_VOLUME("Line In Capture Volume", 0x1b, 0x2, HDA_INPUT),
+	HDA_CODEC_MUTE("Line In Capture Switch", 0x1b, 0x2, HDA_INPUT),
 
 	/*
-	HDA_CODEC_VOLUME("Mic Capture Volume", 0x1b, 0x4, HDA_INPUT),
-	HDA_CODEC_MUTE("Mic Capture Switch", 0x1b 0x4, HDA_INPUT),
+	HDA_CODEC_VOLUME("Mic Capture Volume", 0x1b, 0x1, HDA_INPUT),
+	HDA_CODEC_MUTE("Mic Capture Switch", 0x1b 0x1, HDA_INPUT),
 	*/
 	{ } /* end */
 };
#1 lore raw

At Sat, 20 Dec 2008 17:47:24 -0500,

Quoted 5 lines · Matthew Ranostay

Fixed incorrect mixer index values for 92hd83xx codec's audio input mixer.

Signed-off-by Matthew Ranostay <[email protected]>

Applied this one, too.

Regarding this change: what I've been concerned by the recent patch_sigmatel.c are that the input routes are fixed, and capture mixer elements are often too messy and not intuitive.

Hopefully we can sort out these later...

Thanks,

Takashi

author
#2 lore raw
Quoted 5 lines · Takashi Iwai

At Sat, 20 Dec 2008 17:47:24 -0500,

Quoted 3 lines · Matthew Ranostay

Fixed incorrect mixer index values for 92hd83xx codec's audio input mixer.

Quoted 8 lines
Quoted 1 line
Signed-off-by Matthew Ranostay <[email protected]>

Applied this one, too.

Regarding this change: what I've been concerned by the recent patch_sigmatel.c are that the input routes are fixed, and capture mixer elements are often too messy and not intuitive.

Yeah, there has to be better way to do this.

Quoted 7 lines

Hopefully we can sort out these later...

Thanks,

Takashi