Skip to contentSkip to conversation

cpumask: fix compile error in kernel/irq/proc.c

PATCH In review Li Zefan 3 participants 3 messages Dec 31, 2008 IRQ

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 cpumask: fix compile error in kernel/irq/proc.c

Impact: Fix compile error

Pass correct argument type to is_affinity_mask_valid().

Signed-off-by Li Zefan <[email protected]>
---
 kernel/irq/proc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/irq/proc.c +1 -1
index 2abd3a7..5a5ac60 100644
@@ -111,7 +111,7 @@ static ssize_t default_affinity_write(struct file *file,
 	if (err)
 		goto out;
 
-	if (!is_affinity_mask_valid(new_value)) {
+	if (!is_affinity_mask_valid(*new_value)) {
 		err = -EINVAL;
 		goto out;
 	}
Signature · 1 line
1.5.4.rc3
#1 lore raw

kernel/irq/proc.c static ssize_t default_affinity_write(struct file *file, · line 117

Quoted 13 lines · On Wednesday 31 December 2008 19:29:06 Li Zefan wrote:
kernel/irq/proc.c +1 -1
index 2abd3a7..5a5ac60 100644
@@ -111,7 +111,7 @@ static ssize_t default_affinity_write(struct file *file,
 	if (err)
 		goto out;
 
-	if (!is_affinity_mask_valid(new_value)) {
+	if (!is_affinity_mask_valid(*new_value)) {
 		err = -EINVAL;
 		goto out;
 	}

This looks like one for Mike: I have *new_value in the cpumask tree.

Mike?

Thanks,
Rusty.

#2 lore raw
Quoted 17 lines · Rusty Russell

kernel/irq/proc.c static ssize_t default_affinity_write(struct file *file, · line 117

Quoted 13 lines · On Wednesday 31 December 2008 19:29:06 Li Zefan wrote:
kernel/irq/proc.c +1 -1
index 2abd3a7..5a5ac60 100644
@@ -111,7 +111,7 @@ static ssize_t default_affinity_write(struct file *file,
 	if (err)
 		goto out;
 
-	if (!is_affinity_mask_valid(new_value)) {
+	if (!is_affinity_mask_valid(*new_value)) {
 		err = -EINVAL;
 		goto out;
 	}

This looks like one for Mike: I have *new_value in the cpumask tree.

Quoted 4 lines

Mike?

Thanks,
Rusty.

I have the old value, but then I don't have any affinity changes in my tree. Aren't those all in your cpumask tree?

Thanks,
Mike