Skip to contentSkip to conversation

Eliminate most of sparc_ksyms_*.c

PATCH Superseded Julian Calaby 3 participants 5 messages Jan 6, 2009

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Eliminate most of sparc_ksyms_*.c

Hi all,

This patch set eliminates most of the definitions within arch/sparc/kernel/sparc_ksyms_*.c by moving them to their rightful places.

This is done within patches 1-3.

Note that this work was originally performed by Sam Ravnborg and these patches have been rebased and added to by myself.

I've tried to reflect this in the commit messages but may have gotten it a little wrong.

Patches 4 and 5 are cleanups that I had in my tree for an eventual oplib_*.h unification - but as this screws up my original patches and they're so small, I figured this'd be as good a time as any to send them.

Thanks,

Julian Calaby

#1 lore raw
Quoted 10 lines · Julian Calaby

Hi all,

This patch set eliminates most of the definitions within arch/sparc/kernel/sparc_ksyms_*.c by moving them to their rightful places.

This is done within patches 1-3.

Note that this work was originally performed by Sam Ravnborg and these patches have been rebased and added to by myself.

Quoted 6 lines

I've tried to reflect this in the commit messages but may have gotten it a little wrong.

Patches 4 and 5 are cleanups that I had in my tree for an eventual oplib_*.h unification - but as this screws up my original patches and they're so small, I figured this'd be as good a time as any to send them.

Hi Julian.

I appreciate you took over this patch-set - thanks!

I have not yet looked over the patches. But at first glance it looked like they were word-wrapped??
Anyway - I will let you know if/when I get to it.

Sam

#2 lore raw
In reply to Julian Calaby

From: Sam Ravnborg <[email protected]>
Date: Tue, 6 Jan 2009 21:44:04 +0100

Quoted 4 lines

I appreciate you took over this patch-set - thanks!

I have not yet looked over the patches. But at first glance it looked like they were word-wrapped??

Also initial spaces were transformed to 2 spaces in the patch.

This happened to all his previous patch postings too, but I just silently fixed them up by hand. :-/

#3 lore raw
In reply to Julian Calaby
Quoted 5 lines · David Miller

From: Sam Ravnborg <[email protected]>
Date: Tue, 6 Jan 2009 21:44:04 +0100

Quoted 2 lines

I appreciate you took over this patch-set - thanks!

Quoted 8 lines
Quoted 2 lines

I have not yet looked over the patches. But at first glance it looked like they were word-wrapped??

Also initial spaces were transformed to 2 spaces in the patch.

This happened to all his previous patch postings too, but I just silently fixed them up by hand. :-/

Julian - can I ask you to read Documentation/email-clients.txt and fix your setup of Thunderbird and resumit the serie. You can then include your fix to one of your patches as you already posted.

Thanks,
Sam

#4 lore raw
In reply to Julian Calaby
Quoted 5 lines · David Miller

From: Sam Ravnborg <[email protected]>
Date: Tue, 6 Jan 2009 21:44:04 +0100

Quoted 2 lines

I appreciate you took over this patch-set - thanks!

Quoted 8 lines
Quoted 2 lines

I have not yet looked over the patches. But at first glance it looked like they were word-wrapped??

Also initial spaces were transformed to 2 spaces in the patch.

This happened to all his previous patch postings too, but I just silently fixed them up by hand. :-/

Sodding heck. I thought that as nobody had complained before, everything was working as it should.

Ok, I'll resubmit with my fixes (and there's another hunk that needs to be stuck into patch 3 now too, fecking build test failures) some time today, hopefully at lunchtime.

Hopefully setting up Thunderbird (well, Icedove) will be pain free. =)

Thanks,

Signature · 3 lines
Julian Calaby

Email: [email protected]