Skip to contentSkip to conversation

tracing/ftrace: add missing unlock in register_stat_tracer()

PATCH Applied Li Zefan 3 participants 3 messages Jan 15, 2009 Tracing

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 tracing/ftrace: add missing unlock in register_stat_tracer()

We should unlock all_stat_sessions_mutex before returning failure.

---

I noticed Ingo tend to delete the impact line from my changelog if it added nothing new to the title, so no impact line for this patch. :)

---
 kernel/trace/trace_stat.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
kernel/trace/trace_stat.c +3 -1
index cb29282..8669f3c 100644
@@ -73,8 +73,10 @@ int register_stat_tracer(struct tracer_stat *trace)
 	/* Already registered? */
 	mutex_lock(&all_stat_sessions_mutex);
 	list_for_each_entry_safe(node, tmp, &all_stat_sessions, session_list) {
-		if (node->ts == trace)
+		if (node->ts == trace) {
+			mutex_unlock(all_stat_sessions_mutex);
 			return -EINVAL;
+		}
 	}
 	mutex_unlock(&all_stat_sessions_mutex);
 
Signature · 1 line
1.5.4.rc3
#2 lore raw
In reply to Li Zefan

2009/1/15 Li Zefan <[email protected]>:

Quoted 1 line

We should unlock all_stat_sessions_mutex before returning failure.

Ouch.... Thanks Li!

Quoted 30 lines

---

I noticed Ingo tend to delete the impact line from my changelog if it added nothing new to the title, so no impact line for this patch. :)

---
 kernel/trace/trace_stat.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
kernel/trace/trace_stat.c +3 -2
index cb29282..8669f3c 100644
@@ -73,8 +73,10 @@ int register_stat_tracer(struct tracer_stat *trace)
       /* Already registered? */
       mutex_lock(&all_stat_sessions_mutex);
       list_for_each_entry_safe(node, tmp, &all_stat_sessions, session_list) {
-               if (node->ts == trace)
+               if (node->ts == trace) {
+                       mutex_unlock(all_stat_sessions_mutex);
                       return -EINVAL;
+               }
       }
       mutex_unlock(&all_stat_sessions_mutex);
 
--

1.5.4.rc3