Skip to contentSkip to conversation

leds: Fix bounds checking of wm8350->pmic.led

PATCH Applied Roel Kluin 3 participants 4 messages Jan 17, 2009

Subsystems (2)
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 leds: Fix bounds checking of wm8350->pmic.led

Fix bounds checking of wm8350->pmic.led

---

drivers/regulator/wm8350-regulator.c +1 -1
index 7aa3524..5056e23 100644
@@ -1435,7 +1435,7 @@ int wm8350_register_led(struct wm8350 *wm8350, int lednum, int dcdc, int isink,
 	struct platform_device *pdev;
 	int ret;
 
-	if (lednum > ARRAY_SIZE(wm8350->pmic.led) || lednum < 0) {
+	if (lednum >= ARRAY_SIZE(wm8350->pmic.led) || lednum < 0) {
 		dev_err(wm8350->dev, "Invalid LED index %d\n", lednum);
 		return -ENODEV;
 	}
#2 lore raw
Quoted 2 lines · Mark Brown

but it probably ought to get pushed out via MFD - I'll send it along to Samuel.

Eh, sorry - I meant regulator and Liam

#3 lore raw
In reply to Roel Kluin
Quoted 9 lines · Roel Kluin

Fix bounds checking of wm8350->pmic.led

---

drivers/regulator/wm8350-regulator.c +0 -0
index 7aa3524..5056e23 100644

drivers/regulator/wm8350-regulator.c int wm8350_register_led(struct wm8350 *wm8350, int lednum, int dcdc, int isink,

Quoted 9 lines
drivers/regulator/wm8350-regulator.c +1 -2
@@ -1435,7 +1435,7 @@ int wm8350_register_led(struct wm8350 *wm8350, int lednum, int dcdc, int isink,
 	struct platform_device *pdev;
 	int ret;
 
-	if (lednum > ARRAY_SIZE(wm8350->pmic.led) || lednum < 0) {
+	if (lednum >= ARRAY_SIZE(wm8350->pmic.led) || lednum < 0) {
 		dev_err(wm8350->dev, "Invalid LED index %d\n", lednum);
 		return -ENODEV;
 	}
--

Applied.

Thanks

Liam