Skip to contentSkip to conversation

V4L/DVB: make card signed

PATCH In review Roel Kluin 2 participants 2 messages Jan 18, 2009 – Jan 29, 2009 Media (V4L/DVB)

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 V4L/DVB: make card signed

Is this correct?
--------------->8----------8<----------------
make card signed

Signed-off-by Roel Kluin <[email protected]>

---

drivers/media/video/em28xx/em28xx-cards.c +1 -1
index ef9bf00..7c7a96c 100644
@@ -47,7 +47,7 @@ static unsigned int disable_ir;
 module_param(disable_ir, int, 0444);
 MODULE_PARM_DESC(disable_ir, "disable infrared remote support");
 
-static unsigned int card[]     = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
+static int card[]     = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
 module_param_array(card,  int, NULL, 0444);
 MODULE_PARM_DESC(card,     "card type");
#1 lore raw
Quoted 1 line · On Sun, 18 Jan 2009 15:55:15 +0100 Roel Kluin <[email protected]> wrote:

Is this correct?

No, it isn't. There's no sense on a negative value for a card.

Quoted 22 lines

--------------->8----------8<----------------
make card signed

Signed-off-by Roel Kluin <[email protected]>

---

drivers/media/video/em28xx/em28xx-cards.c +1 -2
index ef9bf00..7c7a96c 100644
@@ -47,7 +47,7 @@ static unsigned int disable_ir;
 module_param(disable_ir, int, 0444);
 MODULE_PARM_DESC(disable_ir, "disable infrared remote support");
 
-static unsigned int card[]     = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
+static int card[]     = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
 module_param_array(card,  int, NULL, 0444);
 MODULE_PARM_DESC(card,     "card type");
 
--

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Cheers,
Mauro