make boguscnt signed and less bogus.

PATCH New Roel Kluin 1 participant 1 message Jan 18, 2009

Subsystems (2)

Network drivers SuperH

lore

Share & tools

lore

Roel Kluin

author

2009-01-18 20:29 UTC #0 lore raw

PATCH 1/1 make boguscnt signed and less bogus.

below in this function is:

if (--boguscnt < 0) {
	printk(KERN_WARNING
		"%s: Too much work at interrupt, status=0x%4.4x.\n",
		ndev->name, intr_status);
}

I am not sure it's sane like this, but at least it appears less insane.

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/sh_eth.c +2 -1

index 7f8e514..3b9c20a 100644
@@ -687,7 +687,8 @@ static irqreturn_t sh_eth_interrupt(int irq, void *netdev)
 {
 	struct net_device *ndev = netdev;
 	struct sh_eth_private *mdp = netdev_priv(ndev);
-	u32 ioaddr, boguscnt = RX_RING_SIZE;
+	u32 ioaddr;
+	int boguscnt = RX_RING_SIZE;
 	u32 intr_status = 0;
 
 	ioaddr = ndev->base_addr;