Skip to contentSkip to conversation

uml: sigprocmask fix

DISCUSSION Shane Hathaway 2 participants 3 messages Jan 20, 2009 – Jan 22, 2009

lore
Share & tools
lore
#0 lore raw

I just ran into the same issue described here:

http://lkml.org/lkml/2009/1/15/194

Like Americo Wang, my user mode linux compile failed when attempting to link ".tmp_vmlinux". However, his patch is probably wrong. The problem is that the name "sigprocmask" is getting renamed to "kernel_sigprocmask" by a compiler directive in arch/um/Makefile, then that name gets mangled into "sys_kernel_sigprocmask" by the SYSCALL_DEFINE3(sigprocmask, ...) macro in kernel/signal.c.

So I added the following line to arch/um/sys-i386/sys_call_table.S:

#define sys_sigprocmask sys_kernel_sigprocmask

This made it compile and link correctly. Look at the symbols generated by the compile of signal.c to see what I mean:

# nm kernel/signal.o | grep sigprocmask
0000008f r __kstrtab_kernel_sigprocmask
00000040 r __ksymtab_kernel_sigprocmask
00001ea6 T kernel_sigprocmask
00002d67 T sys_kernel_sigprocmask
00001faf T sys_rt_sigprocmask

Unfortunately, it's a mystery to me that others haven't run into this before.

Shane

#1 lore raw
Quoted 10 lines · Shane Hathaway

I just ran into the same issue described here:

http://lkml.org/lkml/2009/1/15/194

Like Americo Wang, my user mode linux compile failed when attempting to link ".tmp_vmlinux". However, his patch is probably wrong. The problem is that the name "sigprocmask" is getting renamed to "kernel_sigprocmask" by a compiler directive in arch/um/Makefile, then that name gets mangled into "sys_kernel_sigprocmask" by the SYSCALL_DEFINE3(sigprocmask, ...) macro in kernel/signal.c.

Hmmm, I found this, but note that replacing sigprocmask with kernel_sigprocmask is done by strip, that should be after compiling. But macros are processed before compiling.

Am I missing something?

Thanks.

Signature · 1 line
"Against stupidity, the gods themselves, contend in vain."
#2 lore raw
Quoted 13 lines · Américo Wang
Quoted 10 lines · Shane Hathaway

I just ran into the same issue described here:

http://lkml.org/lkml/2009/1/15/194

Like Americo Wang, my user mode linux compile failed when attempting to link ".tmp_vmlinux". However, his patch is probably wrong. The problem is that the name "sigprocmask" is getting renamed to "kernel_sigprocmask" by a compiler directive in arch/um/Makefile, then that name gets mangled into "sys_kernel_sigprocmask" by the SYSCALL_DEFINE3(sigprocmask, ...) macro in kernel/signal.c.

Quoted 5 lines

Hmmm, I found this, but note that replacing sigprocmask with kernel_sigprocmask is done by strip, that should be after compiling. But macros are processed before compiling.

Am I missing something?

Probably not, but have you made progress in figuring out why others can apparently successfully compile UML without patching sys_call_table.S at all? That's the real mystery.

Shane