Skip to contentSkip to conversation

Extremely slow graphic updates

PATCH New Stefano Stabellini 1 participant 1 message Jan 20, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Extremely slow graphic updates

Hi all,
as you may be already aware of, the last displaystate interface change slowed down the qemu monitor and the text vga text mode in general much more then expected.
The reason for this is that to update the sdl window we are calling SDL_Flip instead of SDL_UpdateRect.
SDL_Flip is necessary to update the SDL window when using double buffering, when double buffering is disable it just falls back to SDL_UpdateRect updating the whole screen.
So in our case we do not use double buffering so we are updating the whole screen every time for no reason.
This patch fixes that.

sdl.c +1 -1
index 73396e8..0c4a3e1 100644
@@ -62,7 +62,7 @@ static void sdl_update(DisplayState *ds, int x, int y, int w, int h)
     //    printf("updating x=%d y=%d w=%d h=%d\n", x, y, w, h);
 
     SDL_BlitSurface(guest_screen, &rec, real_screen, &rec);
-    SDL_Flip(real_screen);
+    SDL_UpdateRect(real_screen, x, y, w, h);
 }
 
 static void sdl_setdata(DisplayState *ds)