Skip to contentSkip to conversation

atiixp: change parameter to macro define

PATCH In review Matthew Ranostay 2 participants 2 messages Jan 23, 2009 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 atiixp: change parameter to macro define

Change 0x15bd parameter to PCI_VENDOR_ID_DFI define.

---

sound/pci/atiixp.c +1 -1
index 9ce8548..6baa6c4 100644
@@ -297,7 +297,7 @@ static struct pci_device_id snd_atiixp_ids[] = {
 MODULE_DEVICE_TABLE(pci, snd_atiixp_ids);
 
 static struct snd_pci_quirk atiixp_quirks[] __devinitdata = {
-	SND_PCI_QUIRK(0x15bd, 0x3100, "DFI RS482", 0),
+	SND_PCI_QUIRK(PCI_VENDOR_ID_DFI, 0x3100, "DFI RS482", 0),
 	{ } /* terminator */
 };
#1 lore raw

At Thu, 22 Jan 2009 21:48:51 -0500,

Quoted 4 lines · Matthew Ranostay

Change 0x15bd parameter to PCI_VENDOR_ID_DFI define.

Well, I won't apply this. PCI_VENDOR_ID_* isn't always good especially for some table. You'll often need to check a certain PCI (SS)ID, and the literal makes the comparison hard.

OTOH, with PCI_VENDOR_ID_*, a number-typo can be avoided better, so it's good as a first place.

Takashi

Quoted 15 lines
sound/pci/atiixp.c +1 -1
index 9ce8548..6baa6c4 100644
@@ -297,7 +297,7 @@ static struct pci_device_id snd_atiixp_ids[] = {
 MODULE_DEVICE_TABLE(pci, snd_atiixp_ids);
 
 static struct snd_pci_quirk atiixp_quirks[] __devinitdata = {
-	SND_PCI_QUIRK(0x15bd, 0x3100, "DFI RS482", 0),
+	SND_PCI_QUIRK(PCI_VENDOR_ID_DFI, 0x3100, "DFI RS482", 0),
 	{ } /* terminator */
 };