Skip to contentSkip to conversation

Remove static type from gunzip_bmp()

PATCH Superseded Mark Jackson 2 participants 2 messages Jan 27, 2009

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Remove static type from gunzip_bmp()

The current bmp routines support gzipped files, but compilation fails (under AVR32) due to the gunzip_bmp() function being defined as static.

This patch fixes this problem.

---

  common/cmd_bmp.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
common/cmd_bmp.c +1 -1
index bc08b26..084ef98 100644
@@ -46,7 +46,7 @@ int gunzip(void *, int, unsigned char *, unsigned long *);
   * didn't contain a valid BMP signature.
   */
  #ifdef CONFIG_VIDEO_BMP_GZIP
-static bmp_image_t *gunzip_bmp(unsigned long addr, unsigned long *lenp)
+bmp_image_t *gunzip_bmp(unsigned long addr, unsigned long *lenp)
  {
  	void *dst;
  	unsigned long len;
@@ -85,7 +85,7 @@ static bmp_image_t *gunzip_bmp(unsigned long addr, unsigned 

long *lenp)
return bmp;
}
#else
-static bmp_image_t *gunzip_bmp(unsigned long addr, unsigned long *lenp) +bmp_image_t *gunzip_bmp(unsigned long addr, unsigned long *lenp)
{
return NULL;
}

#1 lore raw

PATCH v2 1/1 Remove static type from gunzip_bmp()

Dear Mark Jackson,

Quoted 6 lines · In message <[email protected]> you wrote:

The current bmp routines support gzipped files, but compilation fails (under AVR32) due to the gunzip_bmp() function being defined as static.

This patch fixes this problem.

As mentioned before: if you make this function publicly visible, then please also add a prototype declaration for it (and get rid of any private "external ..." declararions elsewhere).

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The greatest warriors are the ones who fight for peace."
- Holly Near