Skip to contentSkip to conversation

MIPS: in plat_time_init() t reaches -1, tested: 0

PATCH Applied Roel Kluin 2 participants 2 messages Jan 31, 2009 – Feb 4, 2009 MIPS

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 MIPS: in plat_time_init() t reaches -1, tested: 0

With a postfix decrement t reaches -1 rather than 0, so the fall-back will not occur.

Signed-off-by Roel Kluin <[email protected]>

---

arch/mips/alchemy/common/time.c +3 -3
index 3288014..0b5681a 100644
@@ -118,7 +118,7 @@ void __init plat_time_init(void)
 	 * setup counter 1 (RTC) to tick at full speed
 	 */
 	t = 0xffffff;
-	while ((au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_T1S) && t--)
+	while ((au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_T1S) && --t)
 		asm volatile ("nop");
 	if (!t)
 		goto cntr_err;

@@ -127,7 +127,7 @@ void __init plat_time_init(void)
 	au_sync();
 
 	t = 0xffffff;
-	while ((au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_C1S) && t--)
+	while ((au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_C1S) && --t)
 		asm volatile ("nop");
 	if (!t)
 		goto cntr_err;

@@ -135,7 +135,7 @@ void __init plat_time_init(void)
 	au_sync();
 
 	t = 0xffffff;
-	while ((au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_C1S) && t--)
+	while ((au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_C1S) && --t)
 		asm volatile ("nop");
 	if (!t)
 		goto cntr_err;
Applied
#1 lore raw
Quoted 2 lines · Roel Kluin

With a postfix decrement t reaches -1 rather than 0, so the fall-back will not occur.

Thanks, applied.

Ralf