cassini: limit reaches -1

PATCH New Roel Kluin 1 participant 1 message Jan 31, 2009

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Roel Kluin

author

2009-01-31 15:08 UTC #0 lore raw

PATCH 1/1 cassini: limit reaches -1

With a postfix decrement limit reaches -1, but on 0 the function already returns false.

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/cassini.c +2 -2

index 840b3d1..bbbc3bb 100644
@@ -806,7 +806,7 @@ static int cas_reset_mii_phy(struct cas *cp)
 
 	cas_phy_write(cp, MII_BMCR, BMCR_RESET);
 	udelay(100);
-	while (limit--) {
+	while (--limit) {
 		val = cas_phy_read(cp, MII_BMCR);
 		if ((val & BMCR_RESET) == 0)
 			break;

@@ -979,7 +979,7 @@ static void cas_phy_init(struct cas *cp)
 		writel(val, cp->regs + REG_PCS_MII_CTRL);
 
 		limit = STOP_TRIES;
-		while (limit-- > 0) {
+		while (--limit > 0) {
 			udelay(10);
 			if ((readl(cp->regs + REG_PCS_MII_CTRL) &
 			     PCS_MII_RESET) == 0)