dm_get_dirattrs can write past end of user buffer
I have observed segfaults with an application that calls dm_get_dirattrs with the latest DMAPI kernel built from SGI CVS.
The problem appears to be in dm_filldir:
needed = dm_stat_size(namelen + 1); ... error = -xfs_dm_bulkattr_iget_one(cb->mp, ino, 0, statp, needed); ... /* * On return from bulkstat_one(), stap->_link points * at the end of the handle in the stat structure. */ statp->dt_compname.vd_offset = statp->_link; statp->dt_compname.vd_length = namelen + 1;
xfs_dm_bulkattr_iget_one() sets statp->_link to needed, so the name ends up getting written past the space reserved for the name, which can exceed cb->spaceleft.
The below patch appears to fix the problem.
Index: fs/xfs/dmapi/xfs_dm.c
===================================================================
RCS file: /cvs/linux-2.6-xfs/fs/xfs/dmapi/xfs_dm.c,v retrieving revision 1.81
xfs/dmapi/xfs_dm.c +0 -0
@@ -1793,7 +1793,7 @@
memset(statp, 0, dm_stat_size(MAXNAMLEN)); error = -xfs_dm_bulkattr_iget_one(cb->mp, ino, 0, - statp, needed); + statp, DM_STAT_SIZE(*statp, 0)); if (error) goto out_err;
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 1 line · Kevin Jamieson
The below patch appears to fix the problem.
The patch looks okay, but I don't think there's any uptodate tree that includes dmapi support.
Btw, we'd also need to have a
please read Documentation/SubmittingPatches in the kernel tree and make sure you agree with the conditions for the Signed-off-by:.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs