Skip to contentSkip to conversation

usb-serial: fix the aircable_init failure path

PATCH In review Dave Young 2 participants 2 messages Feb 1, 2009 – Feb 3, 2009

Subsystems (2)
lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 2/2 usb-serial: fix the aircable_init failure path

The failure path of aircable_init is wrong, fix the order of (goto) labels.

---
drivers/usb/serial/aircable.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/serial/aircable.c +2 -2
diff -uprN a/drivers/usb/serial/aircable.c b/drivers/usb/serial/aircable.c
@@ -621,9 +621,9 @@ static int __init aircable_init(void)
 		goto failed_usb_register;
 	return 0;
 
-failed_serial_register:
-	usb_serial_deregister(&aircable_device);
 failed_usb_register:
+	usb_serial_deregister(&aircable_device);
+failed_serial_register:
 	return retval;
 }
 
Acked-by on v1 2/2
#1 lore raw
Quoted 28 lines

The failure path of aircable_init is wrong, fix the order of (goto) labels.

---
drivers/usb/serial/aircable.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

diff -uprN a/drivers/usb/serial/aircable.c b/drivers/usb/serial/aircable.c

drivers/usb/serial/aircable.c +2 -3
@@ -621,9 +621,9 @@ static int __init aircable_init(void)
 		goto failed_usb_register;
 	return 0;
 
-failed_serial_register:
-	usb_serial_deregister(&aircable_device);
 failed_usb_register:
+	usb_serial_deregister(&aircable_device);
+failed_serial_register:
 	return retval;
 }
 
--

To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html