Skip to contentSkip to conversation

pcm_oss: AFMT_S24_LE is set twice in return value

PATCH Applied Roel Kluin 2 participants 2 messages Feb 4, 2009 Sound

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 pcm_oss: AFMT_S24_LE is set twice in return value

vi sound/core/oss/pcm_oss.c +640
#define AFMT_S24_LE 0x00008000
#define AFMT_S24_BE 0x00010000

---------------------->8----------------------8<------------------- AFMT_S24_LE is set twice in return value

---

sound/core/oss/pcm_oss.c +1 -1
index e178366..0a1798e 100644
@@ -1767,7 +1767,7 @@ static int snd_pcm_oss_get_formats(struct snd_pcm_oss_file *pcm_oss_file)
 		       AFMT_S8 | AFMT_U16_LE |
 		       AFMT_U16_BE |
 			AFMT_S32_LE | AFMT_S32_BE |
-			AFMT_S24_LE | AFMT_S24_LE |
+			AFMT_S24_LE | AFMT_S24_BE |
 			AFMT_S24_PACKED;
 	params = kmalloc(sizeof(*params), GFP_KERNEL);
 	if (!params)
Applied
#1 lore raw

At Wed, 04 Feb 2009 18:14:55 +0100,

Quoted 9 lines · Roel Kluin

vi sound/core/oss/pcm_oss.c +640
#define AFMT_S24_LE 0x00008000
#define AFMT_S24_BE 0x00010000

---------------------->8----------------------8<------------------- AFMT_S24_LE is set twice in return value

Thanks, applied now.

Takashi

Quoted 15 lines

---

sound/core/oss/pcm_oss.c +1 -1
index e178366..0a1798e 100644
@@ -1767,7 +1767,7 @@ static int snd_pcm_oss_get_formats(struct snd_pcm_oss_file *pcm_oss_file)
 		       AFMT_S8 | AFMT_U16_LE |
 		       AFMT_U16_BE |
 			AFMT_S32_LE | AFMT_S32_BE |
-			AFMT_S24_LE | AFMT_S24_LE |
+			AFMT_S24_LE | AFMT_S24_BE |
 			AFMT_S24_PACKED;
 	params = kmalloc(sizeof(*params), GFP_KERNEL);
 	if (!params)