Skip to contentSkip to conversation

netfilter: sctp chunk mapping doesn't work

PATCH Applied Nicolas Dichtel 2 participants 2 messages Feb 5, 2009 – Feb 9, 2009

Subsystems (3)
Networking Network drivers netfilter
lore
Share & tools
lore

Nicolas Dichtel

author
#0 lore raw

PATCH 1/1 netfilter: sctp chunk mapping doesn't work

When user tries to map all chunks given in argument, kernel works on a copy of the chunkmap, but at the end it doesn't check the copy, but the orginal one.

Signed-off-by Qu Haoran <[email protected]>
Signed-off-by Nicolas Dichtel <[email protected]>
net/netfilter/xt_sctp.c +1 -1
@@ -105,7 +105,7 @@ match_packet(const struct sk_buff *skb,
 
 	switch (chunk_match_type) {
 	case SCTP_CHUNK_MATCH_ALL:
-		return SCTP_CHUNKMAP_IS_CLEAR(info->chunkmap);
+		return SCTP_CHUNKMAP_IS_CLEAR(chunkmapcopy);
 	case SCTP_CHUNK_MATCH_ANY:
 		return false;
 	case SCTP_CHUNK_MATCH_ONLY:
Applied
#1 lore raw
Quoted 1 line · Nicolas Dichtel

When user tries to map all chunks given in argument, kernel works on a copy of the chunkmap, but at the end it doesn't check the copy, but the orginal one.

Applied, thanks Nicolas.