Skip to contentSkip to conversation

Support diskless PC

PATCH In review Stefan Weil 4 participants 8 messages Feb 6, 2009 – Feb 7, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Support diskless PC

Hello,

there is no reason why Qemu should not be able to emulate a diskless PC. This patch allows this configuration without tricks like dummy disks.

Regards
Stefan Weil

There is no reason why Qemu should not be able to emulate a diskless PC. So we support it.

hw/pc.c +2 -0
Index: trunk/hw/pc.c
===================================================================
@@ -1147,6 +1147,7 @@
     .desc = "Standard PC",
     .init = pc_init_pci,
     .ram_require = VGA_RAM_SIZE + PC_MAX_BIOS_SIZE,
+    .nodisk_ok = 1,
     .max_cpus = 255,
 };
 
@@ -1155,5 +1156,6 @@
     .desc = "ISA-only PC",
     .init = pc_init_isa,
     .ram_require = VGA_RAM_SIZE + PC_MAX_BIOS_SIZE,
+    .nodisk_ok = 1,
     .max_cpus = 1,
 };
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Stefan Weil

There is no reason why Qemu should not be able to emulate a diskless PC. So we support it.

Yeah, true!

Quoted 22 lines

Index: trunk/hw/pc.c
===================================================================

hw/pc.c +2 -0
@@ -1147,6 +1147,7 @@
     .desc = "Standard PC",
     .init = pc_init_pci,
     .ram_require = VGA_RAM_SIZE + PC_MAX_BIOS_SIZE,
+    .nodisk_ok = 1,
     .max_cpus = 255,
 };
 
@@ -1155,5 +1156,6 @@
     .desc = "ISA-only PC",
     .init = pc_init_isa,
     .ram_require = VGA_RAM_SIZE + PC_MAX_BIOS_SIZE,
+    .nodisk_ok = 1,
     .max_cpus = 1,
 };
#3 lore raw
In reply to Stefan Weil
Quoted 6 lines · Stefan Weil

Hello,

there is no reason why Qemu should not be able to emulate a diskless PC. This patch allows this configuration without tricks like dummy disks.

What circumstance would you run a VM with no disk, without -kernel, and without -boot n?

Regards,

Anthony Liguori

Quoted 5 lines

Regards
Stefan Weil

#2 lore raw
In reply to Jan Kiszka
Quoted 10 lines · Jan Kiszka
Quoted 3 lines · Stefan Weil

There is no reason why Qemu should not be able to emulate a diskless PC. So we support it.

Yeah, true!

This doesn't fix the old -hda /dev/null hacks when using -kernel. That's unnecessary even without this patch.

Regards,

Anthony Liguori

Quoted 25 lines
Quoted 22 lines

Index: trunk/hw/pc.c
===================================================================

hw/pc.c +2 -0
@@ -1147,6 +1147,7 @@
     .desc = "Standard PC",
     .init = pc_init_pci,
     .ram_require = VGA_RAM_SIZE + PC_MAX_BIOS_SIZE,
+    .nodisk_ok = 1,
     .max_cpus = 255,
 };
 
@@ -1155,5 +1156,6 @@
     .desc = "ISA-only PC",
     .init = pc_init_isa,
     .ram_require = VGA_RAM_SIZE + PC_MAX_BIOS_SIZE,
+    .nodisk_ok = 1,
     .max_cpus = 1,
 };
#4 lore raw
In reply to Anthony Liguori
Quoted 10 lines · Anthony Liguori
Quoted 6 lines · Stefan Weil

Hello,

there is no reason why Qemu should not be able to emulate a diskless PC. This patch allows this configuration without tricks like dummy disks.

What circumstance would you run a VM with no disk, without -kernel, and without -boot n?

For custom BIOSes that are the boot image or retrieve it from somewhere.

Jan

#7 lore raw
In reply to Anthony Liguori
Quoted 10 lines · Anthony Liguori
Quoted 6 lines · Stefan Weil

Hello,

there is no reason why Qemu should not be able to emulate a diskless PC. This patch allows this configuration without tricks like dummy disks.

What circumstance would you run a VM with no disk, without -kernel, and without -boot n?

BIOS/Firmware development. I've never used a disk inside qemu and I use -kernel only twice a year if I change some OS handoff (or MTRR) code. I have to admit I didn't know that -boot existed until you mentioned it in this discussion.

Regards,
Carl-Daniel

Signature · 1 line
http://www.hailfinger.org/
#5 lore raw
In reply to Jan Kiszka
Quoted 11 lines · Jan Kiszka
Quoted 9 lines · Anthony Liguori
Quoted 7 lines · Stefan Weil

Hello,

there is no reason why Qemu should not be able to emulate a diskless PC. This patch allows this configuration without tricks like dummy disks.

Quoted 6 lines
Quoted 3 lines

What circumstance would you run a VM with no disk, without -kernel, and without -boot n?

For custom BIOSes that are the boot image or retrieve it from somewhere.

Well in that case, nodisk should just be completely removed. There is no architecture that doesn't at least run a bios of some form.

Regards,

Anthony Liguori

Quoted 3 lines

Jan

#6 lore raw

PATCH 1/1 Remove nodisk_ok machine feature (was: [PATCH] Support diskless PC)

Quoted 15 lines · Anthony Liguori
Quoted 14 lines · Jan Kiszka
Quoted 11 lines · Anthony Liguori
Quoted 6 lines · Stefan Weil

Hello,

there is no reason why Qemu should not be able to emulate a diskless PC. This patch allows this configuration without tricks like dummy disks.

What circumstance would you run a VM with no disk, without -kernel, and without -boot n?

Quoted 5 lines
Quoted 2 lines

For custom BIOSes that are the boot image or retrieve it from somewhere.

Well in that case, nodisk should just be completely removed. There is no architecture that doesn't at least run a bios of some form.

I was wondering this already, but I was not sure about the motivation for nodisk beyond x86 (if there is any).

------->

All archs have some kind of firmware to load and can be fine with it already. So there is not much use in enforcing the presence of a disk. If the system setup requires one, the user will notice it anyway once the firmware/bios fails to boot from it.

---

 hw/boards.h       |    1 -
 hw/mips_jazz.c    |    2 --
 hw/mips_malta.c   |    1 -
 hw/mips_mipssim.c |    1 -
 hw/mips_r4k.c     |    1 -
 hw/sun4m.c        |   12 ------------
 hw/sun4u.c        |    3 ---
 vl.c              |    4 ----
 8 files changed, 0 insertions(+), 25 deletions(-)
hw/boards.h +0 -1
index 0577f06..b870957 100644
@@ -16,7 +16,6 @@ typedef struct QEMUMachine {
     QEMUMachineInitFunc *init;
 #define RAMSIZE_FIXED	(1 << 0)
     ram_addr_t ram_require;
-    int nodisk_ok;
     int use_scsi;
     int max_cpus;
     struct QEMUMachine *next;
hw/mips_jazz.c +0 -2
index 9bdb903..7475517 100644
@@ -294,7 +294,6 @@ QEMUMachine mips_magnum_machine = {
     .desc = "MIPS Magnum",
     .init = mips_magnum_init,
     .ram_require = MAGNUM_BIOS_SIZE + VGA_RAM_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
 };
 
@@ -303,6 +302,5 @@ QEMUMachine mips_pica61_machine = {
     .desc = "Acer Pica 61",
     .init = mips_pica61_init,
     .ram_require = MAGNUM_BIOS_SIZE + VGA_RAM_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
 };
hw/mips_malta.c +0 -1
index b7afb2d..e2e5e41 100644
@@ -950,5 +950,4 @@ QEMUMachine mips_malta_machine = {
     .desc = "MIPS Malta Core LV",
     .init = mips_malta_init,
     .ram_require = VGA_RAM_SIZE + BIOS_SIZE,
-    .nodisk_ok = 1,
 };
hw/mips_mipssim.c +0 -1
index 3f54900..5fb58e4 100644
@@ -185,5 +185,4 @@ QEMUMachine mips_mipssim_machine = {
     .desc = "MIPS MIPSsim platform",
     .init = mips_mipssim_init,
     .ram_require = BIOS_SIZE + VGA_RAM_SIZE /* unused */,
-    .nodisk_ok = 1,
 };
hw/mips_r4k.c +0 -1
index ab0c110..e6697e9 100644
@@ -282,5 +282,4 @@ QEMUMachine mips_machine = {
     .desc = "mips r4k platform",
     .init = mips_r4k_init,
     .ram_require = VGA_RAM_SIZE + BIOS_SIZE,
-    .nodisk_ok = 1,
 };
hw/sun4m.c +0 -12
index bae8803..6c358fc 100644
@@ -1072,7 +1072,6 @@ QEMUMachine ss5_machine = {
     .desc = "Sun4m platform, SPARCstation 5",
     .init = ss5_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
 };
 
@@ -1081,7 +1080,6 @@ QEMUMachine ss10_machine = {
     .desc = "Sun4m platform, SPARCstation 10",
     .init = ss10_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
     .max_cpus = 4,
 };
@@ -1091,7 +1089,6 @@ QEMUMachine ss600mp_machine = {
     .desc = "Sun4m platform, SPARCserver 600MP",
     .init = ss600mp_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
     .max_cpus = 4,
 };
@@ -1101,7 +1098,6 @@ QEMUMachine ss20_machine = {
     .desc = "Sun4m platform, SPARCstation 20",
     .init = ss20_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
     .max_cpus = 4,
 };
@@ -1111,7 +1107,6 @@ QEMUMachine voyager_machine = {
     .desc = "Sun4m platform, SPARCstation Voyager",
     .init = vger_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
 };
 
@@ -1120,7 +1115,6 @@ QEMUMachine ss_lx_machine = {
     .desc = "Sun4m platform, SPARCstation LX",
     .init = ss_lx_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
 };
 
@@ -1129,7 +1123,6 @@ QEMUMachine ss4_machine = {
     .desc = "Sun4m platform, SPARCstation 4",
     .init = ss4_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
 };
 
@@ -1138,7 +1131,6 @@ QEMUMachine scls_machine = {
     .desc = "Sun4m platform, SPARCClassic",
     .init = scls_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
 };
 
@@ -1147,7 +1139,6 @@ QEMUMachine sbook_machine = {
     .desc = "Sun4m platform, SPARCbook",
     .init = sbook_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
 };
 
@@ -1389,7 +1380,6 @@ QEMUMachine ss1000_machine = {
     .desc = "Sun4d platform, SPARCserver 1000",
     .init = ss1000_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
     .max_cpus = 8,
 };
@@ -1399,7 +1389,6 @@ QEMUMachine ss2000_machine = {
     .desc = "Sun4d platform, SPARCcenter 2000",
     .init = ss2000_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
     .max_cpus = 20,
 };
@@ -1597,6 +1586,5 @@ QEMUMachine ss2_machine = {
     .desc = "Sun4c platform, SPARCstation 2",
     .init = ss2_init,
     .ram_require = PROM_SIZE_MAX + TCX_SIZE,
-    .nodisk_ok = 1,
     .use_scsi = 1,
 };
hw/sun4u.c +0 -3
index 234df7a..230d694 100644
@@ -642,7 +642,6 @@ QEMUMachine sun4u_machine = {
     .desc = "Sun4u platform",
     .init = sun4u_init,
     .ram_require = PROM_SIZE_MAX + VGA_RAM_SIZE,
-    .nodisk_ok = 1,
     .max_cpus = 1, // XXX for now
 };
 
@@ -651,7 +650,6 @@ QEMUMachine sun4v_machine = {
     .desc = "Sun4v platform",
     .init = sun4v_init,
     .ram_require = PROM_SIZE_MAX + VGA_RAM_SIZE,
-    .nodisk_ok = 1,
     .max_cpus = 1, // XXX for now
 };
 
@@ -660,6 +658,5 @@ QEMUMachine niagara_machine = {
     .desc = "Sun4v platform, Niagara",
     .init = niagara_init,
     .ram_require = PROM_SIZE_MAX + VGA_RAM_SIZE,
-    .nodisk_ok = 1,
     .max_cpus = 1, // XXX for now
 };
vl.c +0 -4
index aff2b2c..eb4ca35 100644
@@ -5311,10 +5311,6 @@ int main(int argc, char **argv, char **envp)
     linux_boot = (kernel_filename != NULL);
     net_boot = (boot_devices_bitmap >> ('n' - 'a')) & 0xF;
 
-    if (!linux_boot && net_boot == 0 &&
-        !machine->nodisk_ok && nb_drives_opt == 0)
-        help(1);
-
     if (!linux_boot && *kernel_cmdline != '\0') {
         fprintf(stderr, "-append only allowed with -kernel option\n");
         exit(1);